add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc

src/mod/applications/mod_httapi/mod_httapi.c

@@ -2071,49 +2071,49 @@ static switch_status_t do_config(void)
 
 		profile->auth_scheme = auth_scheme;
 		profile->timeout = timeout;
-		profile->url = strdup(url);
+		profile->url = switch_core_strdup(globals.pool, url);
 		switch_assert(profile->url);
 
 		if (bind_local != NULL) {
-			profile->bind_local = strdup(bind_local);
+			profile->bind_local = switch_core_strdup(globals.pool, bind_local);
 		}
 		if (method != NULL) {
-			profile->method = strdup(method);
+			profile->method = switch_core_strdup(globals.pool, method);
 		} else {
 			profile->method = NULL;
 		}
 
 		if (bind_cred) {
-			profile->cred = strdup(bind_cred);
+			profile->cred = switch_core_strdup(globals.pool, bind_cred);
 		}
 
 		profile->disable100continue = disable100continue;
 		profile->enable_cacert_check = enable_cacert_check;
 
 		if (ssl_cert_file) {
-			profile->ssl_cert_file = strdup(ssl_cert_file);
+			profile->ssl_cert_file = switch_core_strdup(globals.pool, ssl_cert_file);
 		}
 
 		if (ssl_key_file) {
-			profile->ssl_key_file = strdup(ssl_key_file);
+			profile->ssl_key_file = switch_core_strdup(globals.pool, ssl_key_file);
 		}
 
 		if (ssl_key_password) {
-			profile->ssl_key_password = strdup(ssl_key_password);
+			profile->ssl_key_password = switch_core_strdup(globals.pool, ssl_key_password);
 		}
 
 		if (ssl_version) {
-			profile->ssl_version = strdup(ssl_version);
+			profile->ssl_version = switch_core_strdup(globals.pool, ssl_version);
 		}
 
 		if (ssl_cacert_file) {
-			profile->ssl_cacert_file = strdup(ssl_cacert_file);
+			profile->ssl_cacert_file = switch_core_strdup(globals.pool, ssl_cacert_file);
 		}
 
 		profile->enable_ssl_verifyhost = enable_ssl_verifyhost;
 
 		if (cookie_file) {
-			profile->cookie_file = strdup(cookie_file);
+			profile->cookie_file = switch_core_strdup(globals.pool, cookie_file);
 		}
 
 		profile->vars_map = vars_map;
@@ -2138,7 +2138,7 @@ static switch_status_t do_config(void)
 		switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "Profile [%s] JSON Function [%s]\n",
 						  zstr(bname) ? "N/A" : bname, profile->url);
 
-		profile->name = strdup(bname);
+		profile->name = switch_core_strdup(globals.pool, bname);
 
 		switch_core_hash_insert(globals.profile_hash, bname, profile);
 

src/mod/applications/mod_spandsp/mod_spandsp.c

@@ -476,6 +476,12 @@ void mod_spandsp_indicate_data(switch_core_session_t *session, switch_bool_t sel
 /* **************************************************************************
    CONFIGURATION
    ************************************************************************* */
+static void destroy_descriptor(void *ptr)
+{
+    tone_descriptor_t *d = (tone_descriptor_t *) ptr;
+
+    super_tone_rx_free_descriptor(d->spandsp_tone_descriptor);
+}
 
 switch_status_t load_configuration(switch_bool_t reload)
 {
@@ -657,7 +663,8 @@ switch_status_t load_configuration(switch_bool_t reload)
 					switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CRIT, "Unable to allocate tone_descriptor: %s\n", name);
 					switch_goto_status(SWITCH_STATUS_FALSE, done);
 				}
-				switch_core_hash_insert(spandsp_globals.tones, name, descriptor);
+
+				switch_core_hash_insert_destructor(spandsp_globals.tones, name, descriptor, destroy_descriptor);
 
 				/* add tones to descriptor */
 				for (tone = switch_xml_child(xdescriptor, "tone"); tone; tone = switch_xml_next(tone)) {
@@ -830,6 +837,8 @@ SWITCH_MODULE_SHUTDOWN_FUNCTION(mod_spandsp_shutdown)
 		switch_core_destroy_memory_pool(&spandsp_globals.config_pool);
 	}
 
+	memset(&spandsp_globals, 0, sizeof(spandsp_globals));
+
 	return SWITCH_STATUS_UNLOAD;
 }
 

src/mod/applications/mod_spandsp/mod_spandsp_fax.c

@@ -1645,7 +1645,6 @@ void mod_spandsp_fax_shutdown(void)
 	t38_state_list.thread_running = 0;
 	wake_thread(1);
 	switch_thread_join(&tstatus, t38_state_list.thread);
-	memset(&spandsp_globals, 0, sizeof(spandsp_globals));
 }
 
 static const switch_state_handler_table_t t38_gateway_state_handlers;