ben.carrasco/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2026-07-24 13:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mod_dingaling] scan-build: fix multiple dead assignments and dereference of null pointer.

Browse Source
This commit is contained in:
Andrey Volk
2020-02-22 00:33:13 +04:00
parent 1c4627d35c
commit 5082454c45
2 changed files with 10 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mod/endpoints/mod_dingaling/mod_dingaling.c
+3 -10
View File
@@ -680,7 +680,6 @@ static void roster_event_handler(switch_event_t *event)
{
char *status = switch_event_get_header(event, "status");
char *from = switch_event_get_header(event, "from");
char *event_type = switch_event_get_header(event, "event_type");
mdl_profile_t *profile = NULL;
switch_hash_index_t *hi;
void *val;
@@ -694,10 +693,6 @@ static void roster_event_handler(switch_event_t *event)
status = NULL;
}
if (zstr(event_type)) {
event_type = "presence";
}
if (from) {
sql = switch_mprintf("select *,'%q' from jabber_subscriptions where sub_from='%q'", status ? status : "", from);
} else {
@@ -4429,11 +4424,9 @@ static ldl_status handle_signalling(ldl_handle_t *handle, ldl_session_t *dlsessi
break;
case LDL_SIGNAL_CANDIDATES:
if (dl_signal) {
status = LDL_STATUS_SUCCESS;
status = parse_candidates(dlsession, session, LDL_TPORT_RTP, subject);
status = parse_candidates(dlsession, session, LDL_TPORT_VIDEO_RTP, subject);
status = parse_candidates(dlsession, session, LDL_TPORT_RTCP, subject);
parse_candidates(dlsession, session, LDL_TPORT_RTP, subject);
parse_candidates(dlsession, session, LDL_TPORT_VIDEO_RTP, subject);
parse_candidates(dlsession, session, LDL_TPORT_RTCP, subject);
status = parse_candidates(dlsession, session, LDL_TPORT_VIDEO_RTCP, subject);
}