Travis Cross
2068b284cc
mod_fifo: Fix memory leak of xml structure
...
If getting the DB handle failed during the load or reload of the
configuration, we would leak the XML structure we just allocated for
the configuration.
2014-05-28 01:32:00 +00:00
Travis Cross
c6e90e0111
mod_fifo: Refactor out config file reading
2014-05-28 01:32:00 +00:00
Travis Cross
a3a62d2481
mod_fifo: Convert macro to fn and improve name
2014-05-28 01:32:00 +00:00
Travis Cross
06d94d2c17
mod_fifo: Move straggling vars to global struct
2014-05-28 01:31:59 +00:00
Travis Cross
31ae5b4655
mod_fifo: Cleanup whitespace
2014-05-28 01:31:59 +00:00
Travis Cross
f80e869fe0
mod_fifo: Cleanup whitespace in load_config()
2014-05-28 01:31:59 +00:00
Travis Cross
a15058406e
mod_fifo: Cleanup config parsing
2014-05-28 01:31:58 +00:00
Travis Cross
20f35e4591
mod_fifo: Improve function names
2014-05-28 01:31:58 +00:00
Travis Cross
84d6b2e351
mod_fifo: Consolidate code
2014-05-28 01:31:58 +00:00
Travis Cross
8ccd13bd9a
mod_fifo: Document load_config()
2014-05-28 01:31:58 +00:00
Travis Cross
83f69a41e8
Add in-code documentation for mod_fifo
...
The goal here is to describe theory. We want to illuminate what the
code is trying to do and what the core concepts are.
2014-05-28 01:31:57 +00:00
Michael Jerris
c768e4b6e6
CID:1215198 don't set variables that are not used, and clean up the bail out usage condition to be more sane
2014-05-22 14:52:56 +00:00
William King
11f373d4f2
CID: 1215198 Fix an assignment so that the variable only handles malloc'd data.
2014-05-21 16:28:03 -07:00
Marc Olivier Chouinard
29e2263442
CID:1210789 Make return value of a function available from the another calling function. Also add a small status check.
2014-05-16 17:18:17 -04:00
Marc Olivier Chouinard
8fa7398760
CID:1025868 Simplified a function arguments never called.
2014-05-16 17:03:59 -04:00
Michael Jerris
386000d877
CID:1024418 Unintentional integer overflow
2014-05-16 20:07:58 +00:00
Michael Jerris
4238339176
CID:1023970 Unused pointer value
2014-05-16 19:53:23 +00:00
Michael Jerris
6a8002db79
CID:1024582 Logically dead code
2014-05-16 19:27:25 +00:00
Michael Jerris
21a5d166c6
CID:1024581 Logically dead code
2014-05-16 19:22:37 +00:00
Michael Jerris
c1f7887039
CID:1024580 Logically dead code, x will always be > 1
2014-05-16 19:19:31 +00:00
Michael Jerris
73c1e09269
CID:1024579 Logically dead code
2014-05-16 19:09:18 +00:00
Michael Jerris
9b1ebff8de
CID:1024270 Dereference before null check
2014-05-16 18:54:50 +00:00
Michael Jerris
54fc2f5e39
CID:1023975 Unused pointer value
2014-05-16 18:49:23 +00:00
Michael Jerris
a67389ad5c
CID:1025879 Logically dead code
2014-05-16 18:20:25 +00:00
Michael Jerris
ecde431730
CID:1025850 Dereference before null check
2014-05-16 18:15:34 +00:00
Michael Jerris
b10c865c25
CID:1025849 Dereference before null check
2014-05-16 18:12:28 +00:00
Marc Olivier Chouinard
a997331577
CID:1214125 https://scan6.coverity.com:8443/docs/en/cov_checker_ref.html#static_checker_BUFFER_SIZE
2014-05-16 13:30:27 -04:00
Michael Jerris
1b0bdaf85e
CID:1214212 Resource leak in voicemail_list
2014-05-15 14:11:39 +00:00
Michael Jerris
4e888a282c
CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing
2014-05-15 14:09:38 +00:00
Michael Jerris
d2884ac5a6
CID:1214211 Resource leak
2014-05-15 13:58:08 +00:00
Michael Jerris
0469db0305
CID:1214200 Dereference null return value
2014-05-15 13:47:24 +00:00
Michael Jerris
92c6f3abc5
CID:1214192 Dereference after null check, don't crash when no file name passed on file open
2014-05-15 13:37:26 +00:00
Michael Jerris
179e07c649
CID:1214219 Resource leak
2014-05-15 13:30:39 +00:00
Michael Jerris
07b6bba68b
CID:1214209 Resource leak, don't leak event populated by switch_channel_get_variables
2014-05-15 13:22:51 +00:00
Michael Jerris
452d7a3793
CID:1214163 Unchecked return value, check return value of switch_ivr_play_file and bail out if it fails
2014-05-15 13:18:58 +00:00
Michael Jerris
7c72e94a67
CID:1214158 Buffer not null terminated
2014-05-15 12:42:49 +00:00
Michael Jerris
68825ff4f1
CID:1214220 Resource leak
2014-05-15 12:41:09 +00:00
Michael Jerris
619b31e1e8
CID:1214140 Buffer not null terminated, make sure hostname is always null terminated
2014-05-15 12:38:41 +00:00
Michael Jerris
16805187ec
CID:1214256 Unused pointer value
2014-05-15 12:36:36 +00:00
Michael Jerris
128601316f
CID:1214255 Unused pointer value
2014-05-15 12:34:50 +00:00
Michael Jerris
19f3ab5182
CID:1214218 fix memory leak in conference_event_channel_handler
2014-05-15 12:33:15 +00:00
Michael Jerris
622cd21009
CID:1214231 don't leak when using invalid syntax
2014-05-15 12:27:39 +00:00
Michael Jerris
9a1c4f6827
don't pass large strucutre by value
2014-05-12 09:31:12 -04:00
Michael Jerris
3e18f08796
clean up coverity warnings and improve error checking
2014-05-12 09:08:52 -04:00
William King
ad327dffc8
CID: 1211946 fixing uninitialized pointer read in mod_translate
2014-05-07 00:22:56 -07:00
Steve Underwood
38abcf7e2c
The APIs for spandsp FAX have changes, removing one of the parameters passed in
...
the callbacks.
2014-05-04 17:22:28 +08:00
Michael Jerris
9db6d5ba9c
different distros have diff pkg names
2014-05-02 18:35:37 -04:00
Natanael Copa
317f4b1442
Fix building with musl libc
...
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)
limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Travis Cross
fc40e4ab79
Avoid leaking data_buf in mod_conference
...
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated. On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Michael Jerris
582fa1a664
fix typo
2014-05-01 18:22:57 -04:00
Travis Cross