Dragos Oancea
0b5c7307a7
[mod_portaudio] scan-build: Access to field 'next' results in a dereference of a null pointer (loaded from variable 'previous').
...
Value stored to 'codec_ms' is never read.
2020-03-06 13:40:03 +00:00
Dragos Oancea
56e82bd9c0
[mod_verto] scan-build: Value stored to 'cur' is never read
2020-03-06 11:09:29 +00:00
Dragos Oancea
e821be1c18
[mod_skinny] scan-build: Dead assignments
2020-03-05 23:54:19 +00:00
Andrey Volk
c66c314f57
Merge pull request #461 from dragos-oancea/mod_portaudio-val-never-read
...
[mod_portaudio] scan-build: Dead assignments
2020-03-06 00:47:38 +04:00
Andrey Volk
82b8773f84
Merge pull request #432 from dragos-oancea/mod_rtmp-status--val-never-read
...
[mod_rtmp] scan-build: Value stored to 'status' is never read - RTMP_INVOKE_FUNCTION(rtmp_i_sendevent)
2020-03-06 00:39:06 +04:00
Andrey Volk
22ed11a49d
Merge pull request #425 from dragos-oancea/mod_rtmp-val-never-read
...
[mod_rtmp] scan-build: Value stored to 'codec' is never read - rtmp_audio_codec()
2020-03-06 00:36:41 +04:00
Dragos Oancea
e182ecb58b
[mod_portaudio] scan-build: Dead assignments
2020-02-28 13:22:59 +00:00
Dragos Oancea
6b07fa31a4
[mod_skinny] scan-build: Assigned value is garbage or undefined
2020-02-27 14:02:44 +00:00
Dragos Oancea
1a4748a8d0
[mod_rtmp] scan-build: Value stored to 'codec' is never read - rtmp_audio_codec()
2020-02-27 11:01:46 +00:00
Andrey Volk
21577fcdd2
Merge pull request #439 from dragos-oancea/mod_rtmp-profile-nullptr-deref
...
[mod_rtmp] scan-build: Access to field 'name' results in a dereference of a null pointer (loaded from variable 'profile') - config_profile()
2020-02-27 00:03:23 +04:00
Andrey Volk
40251c2cf9
Merge pull request #433 from dragos-oancea/mod_verto-status--val-never-read
...
[mod_verto] scan-build: Value stored to 'status' is never read - verto_read_text_frame()
2020-02-26 23:53:45 +04:00
Andrey Volk
815f26ec15
Merge pull request #428 from dragos-oancea/mod_skinny-val-never-read
...
[mod_skinny] scan-build: Value stored to 'profile' is never read - channel_outgoing_channel()
2020-02-26 23:46:49 +04:00
Dragos Oancea
cec9e173d7
[mod_rtmp] scan-build: Access to field 'name' results in a dereference of a null pointer (loaded from variable 'profile') - config_profile()
2020-02-25 23:55:11 +00:00
Dragos Oancea
ba0221ff09
[mod_verto] scan-build: Value stored to 'status' is never read - verto_read_text_frame()
2020-02-25 21:45:38 +00:00
Dragos Oancea
f99eecdd03
[mod_rtmp] scan-build: Value stored to 'status' is never read - RTMP_INVOKE_FUNCTION(rtmp_i_sendevent)
2020-02-25 21:42:20 +00:00
Dragos Oancea
40c7d62c42
[mod_skinny] scan-build: Value stored to 'profile' is never read - channel_outgoing_channel()
2020-02-25 21:24:36 +00:00
Dragos Oancea
0ad909aec7
[mod_verto] scan-build: Null pointer argument in call to string comparison function - http_run()
2020-02-25 21:18:44 +00:00
Andrey Volk
5082454c45
[mod_dingaling] scan-build: fix multiple dead assignments and dereference of null pointer.
2020-02-22 00:46:10 +04:00
Mike Jerris
39ff576097
[mod_verto] fix crash on vhost http server requests without content type
2020-02-15 13:40:00 -05:00
Dragos Oancea
d23608f0cb
[mod_sofia] scan-build: Access to field 'sip_call_info' results in a dereference of a null pointer (loaded from variable 'sip')
2020-02-12 01:53:24 +00:00
Dragos Oancea
a05f7b8da0
[mod_sofia] scan-build: Access to field 'sip_payload' results in a dereference of a null pointer (loaded from variable 'sip')
2020-01-31 21:52:47 +00:00
Andrey Volk
496d39bbd7
Merge pull request #221 from signalwire/sofia_abort
...
[mod_sofia] Add abort-on-empty-external-ip global param disabled by default.
2020-01-29 21:00:42 +04:00
Andrey Volk
7effdf0565
Merge pull request #232 from signalwire/modtestmake
...
[Unit-tests] Place module tests into their module's Makefile.am, fix tests, add missing Makefile.am to mod_png, implement recursive make check.
2020-01-18 14:24:11 +04:00
Andrey Volk
751d5ff55b
[Unit-tests] Place module tests into their module's Makefile.am, fix tests, add missing Makefile.am to mod_png, implement recursive make check.
2020-01-18 09:58:42 +00:00
Seven Du
a28436deb7
[mod_loopback] add pre_answer and null_auto_answer support to null channel
2020-01-17 20:50:08 +04:00
joshebosh
41000cfbba
[mod_loopback] add channel var loopback_no_pre_answer
2020-01-17 20:47:38 +04:00
Andrey Volk
a074814b3f
[mod_sofia] Add abort-on-empty-external-ip global param disabled by default.
2020-01-11 01:18:14 +04:00
Andrey Volk
8797a0f480
Merge pull request #180 from signalwire/CF_AUDIO
...
[mod_portaudio] CF_AUDIO flag is not set
2020-01-06 22:35:03 +04:00
Andrey Volk
6f0ad146d2
[mod_sofia] Fix crash from double profile unlock on outgoing channel from a gateway on a paused profile
2019-12-31 03:13:03 +04:00
Seven Du
13dc7629d6
[mod_sofia] add sip_refer_status_code channel variable to track refer status
2019-12-31 03:08:58 +04:00
Seven Du
2aec6035dd
[mod_loopback] add refer mock to null endpoint
2019-12-31 03:07:49 +04:00
Seven Du
c7480bc3fe
[mod_loopback] remember dtmf in channel var null_channel_dtmf_queued
2019-12-31 03:05:25 +04:00
Andrey Volk
e753e615ca
[mod_sofia] Module load will fail if ext-rtp-ip or ext-sip-ip configuration param is set as empty string.
2019-12-31 02:17:17 +04:00
Andrey Volk
8442218df1
[mod_sofia] sofia_handle_sip_i_invite() leaks xml and event objects on acl_token, sofia_reg_handle_sip_r_challenge() leaks xml object when a user does not have params.
2019-12-31 00:45:00 +04:00
Andrey Volk
e2c1e3a7d3
FS-12055: [mod_sofia] Fix leaks and release profile properly in general_event_handler() and actual_sofia_presence_event_handler()
2019-12-30 23:58:28 +04:00
Andrey Volk
24e0949844
FS-12056: [mod_sofia] Fix leaking destination in sofia_glue_do_invite() and leaking route in sofia_glue_gen_contact_str()
2019-12-30 23:56:16 +04:00
Andrey Volk
ea6a34aa7d
[mod_portaudio] CF_AUDIO flag is not set
2019-12-17 00:21:52 +04:00
Andrey Volk
2865603ad2
[Unit-tests] Fix xml error not finding freeswitch.xml on FST_MINCORE_BEGIN
2019-11-26 01:54:43 +04:00
Andrey Volk
aa2df4f3f8
Merge pull request #90 from lazedo/k-header
...
[mod_sofia] add K- to prefixes that create a sip_h_ variable
2019-10-31 20:50:05 +04:00
lazedo
b4373c6666
[mod_sofia] add K- to prefixes that create a sip_h_ variable
...
used by sip tracing tools and not to confuse with application (X-) or (P-)
2019-10-31 12:27:21 +00:00
lazedo
f77484b96d
[mod_sofia] add existing variables when locating user
2019-10-31 12:20:33 +00:00
Andrey Volk
311a20af63
[mod_verto] Ignore not just zero but negative frame size as well.
2019-10-23 23:03:18 +04:00
Sebastian Kemper
167294ea26
[mod-sofia] Fix reINVITE after T38 is rejected
...
From FS-11833.
After FS sends a reINVITE to T38 which gets rejected by peer it is no
longer in a state where it can properly answer a reINVITE which requests
a change of the media setup.
1. FS sends INVITE (destination is a fax machine)
2. Call connects with "8 101"
3. FS sends reINVITE to T38
4. T38 rejected (488)
5. FS receives INVITE to "8"
6. FS replies with 200 OK without SDP
7. Call fails
The bug is related to TFLAG_SDP. This flag is set when a media session
is established. And when there's a reINVITE sofia_glue_do_invite() from
sofia_glue.c is called and clears the flag again:
sofia_clear_flag_locked(tech_pvt, TFLAG_SDP);
So when FS sends a reINVITE to T38 the flag gets cleared. But when the
reINVITE is rejected with 488 the flag is not set again. It stays
cleared. So the call continues with the previously negotiated media, fax
passthrough (8 101 in this case), but TFLAG_SDP is not set.
So when FS receives a reINVITE at this point it doesn't see the need to
renegotiate anything, even though it realizes that 2833 DTMF is now off:
2019-04-30 16:42:12.478025 [DEBUG] switch_core_media.c:5478 Audio Codec Compare [PCMA:8:8000:20:64000:1]/[PCMA:8:8000:20:64000:1]
2019-04-30 16:42:12.478025 [DEBUG] switch_core_media.c:5533 Audio Codec Compare [PCMA:8:8000:20:64000:1] ++++ is saved as a match
2019-04-30 16:42:12.478025 [DEBUG] switch_core_media.c:5802 No 2833 in SDP. Disable 2833 dtmf and switch to INFO
When FS doesn't send a reINVITE (fax_enable_t38_request=false) and the
reINVITE to "8" is received, TFLAG_SDP is still set and then FS
understands that it needs to renegotiate and replies with a 200 OK that
includes SDP:
2019-04-30 16:41:19.358028 [DEBUG] switch_core_media.c:5478 Audio Codec Compare [PCMA:8:8000:20:64000:1]/[PCMA:8:8000:20:64000:1]
2019-04-30 16:41:19.358028 [DEBUG] switch_core_media.c:5533 Audio Codec Compare [PCMA:8:8000:20:64000:1] ++++ is saved as a match
2019-04-30 16:41:19.358028 [DEBUG] switch_core_media.c:5802 No 2833 in SDP. Disable 2833 dtmf and switch to INFO
2019-04-30 16:41:19.358028 [DEBUG] sofia.c:8237 skemper was here in line 8232
2019-04-30 16:41:19.358028 [DEBUG] switch_core_media.c:8390 skemper was here in line 8390.
2019-04-30 16:41:19.358028 [DEBUG] switch_core_media.c:8496 Audio params are unchanged for sofia/external/+called_number.
2019-04-30 16:41:19.358028 [DEBUG] sofia.c:8243 Processing updated SDP
This fixes the state problem after a rejected T38 reINVITE by setting
TFLAG_SDP.
Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net >
2019-10-18 21:19:41 +02:00
Chris Rienzo
9d4f480335
[mod_sofia] Fix some incorrect word contractions.
2019-10-10 09:41:53 -04:00
Andrey Volk
fc925a273b
Merge pull request #1809 in FS/freeswitch from sofia-leak to master
...
* commit '20a893fd0683de64353ee2c111aa9c61a867886d':
FS-12038: [mod_sofia, core] Fix potential leak and race in chat_hash, add switch_core_hash_insert_auto_free().
2019-09-06 11:28:31 -05:00
Andrey Volk
20a893fd06
FS-12038: [mod_sofia, core] Fix potential leak and race in chat_hash, add switch_core_hash_insert_auto_free().
2019-09-06 20:22:20 +04:00
Andrey Volk
7ee53a6ec1
FS-12040: [mod_sofia] Fix potential leak if realloc fails.
2019-09-06 18:01:55 +04:00
Andrey Volk
f93445a38c
FS-12010: [sofia-sip] Fix improper cleanup on su_deinit().
2019-08-20 03:11:28 +04:00
Andrey Volk
96aac32237
FS-12010: [mod_sofia, mod_valet_parking, mod_enum] Fix memory leaks on FreeSWITCH shutdown.
2019-08-19 23:14:24 +04:00
Sergey Khripchenko
655c8a1a7b
FS-11362 Attempt to rearrange verto socket shutdown sequence
2019-07-26 00:31:11 +04:00