Commit Graph

11723 Commits

Author SHA1 Message Date
Brian West 5c07c3eb03 don't use memory after free when using naptr with mod_enum with multiple routes 2014-04-28 13:03:09 -05:00
Michael Jerris a83fde3543 block of code in here twice was writing over expanded, causing it to potentially leak 2014-04-28 13:41:48 -04:00
Anthony Minessale cc06d9181b FS-4779 FS-6467 the behaviour from 4479 is now masked behind the param 3pcc-reinvite-bridged-on-ack FS-6467 please test master 2014-04-28 22:10:14 +05:00
Michael Jerris 1affd78204 we only call this with values, and it would crash if you passed it null anyways, just assert to make it 100% clear 2014-04-26 15:41:34 -04:00
Michael Jerris abd7882d18 contact->m_url is an array, don't check array for zero as its useless 2014-04-26 15:35:27 -04:00
Michael Jerris 96c6abbe69 Fix buffer overrun that could have been exploited with a crafted skinny packet designed to exploit this mistake in bounds checking. 2014-04-26 15:29:01 -04:00
Georgiewskiy Yuriy 2e45fc0619 fix memory leaks, tanks to Sharath from packetizer forum. 2014-04-26 04:49:35 +04:00
Brian West 1aa2fc7548 FS-3332 --resolve 2014-04-25 15:53:21 -05:00
William King 0ba59aa6c2 Expanding on 052638186b to support boolean tel url params in mod_sofia 2014-04-25 13:49:59 -07:00
William King f27fe7ed08 BNPH-6470 follow up to commit 68d863a179 removing the original line that performed the curl request to avoid a double request in mod_xml_curl 2014-04-25 12:11:09 -07:00
Brian West 68d863a179 FS-6470 2014-04-25 11:50:06 -05:00
Brian West 7e15c938e2 FS-6482 --resolve 2014-04-24 14:05:18 -05:00
William King bcc2aa9899 Fixing memory leak that would occur when reloading mod_xml_curl 2014-04-24 09:13:00 -07:00
Anthony Minessale 4def48b881 revert 2014-04-24 20:58:23 +05:00
Anthony Minessale 2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Chris Rienzo 25c9b6196b mod_rayo: preserve old caller ID behavior if display name is not given 2014-04-22 13:30:15 -04:00
Chris Rienzo 1eab82ba2d mod_rayo: relax recent caller ID restrictions a bit 2014-04-22 08:50:50 -04:00
Travis Cross 175c9eebca Remove extraneous abort(3) when sending chat
This appears to have been accidentally added in commit
79ebcb104b which sought to provide a
mechanism for disabling Sofia's chat interface.  The abort(3) here
achieved that a bit too well.
2014-04-19 19:26:27 +00:00
Anthony Minessale 79ebcb104b add enable-chat sofia profile param which defaults to true when not present, set to false to turn off the chat interface in sofia 2014-04-19 12:29:10 -05:00
Brian West 265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West 190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
Seven Du 37ee4299fb fix compiler warning 2014-04-17 14:58:18 +08:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
William King 748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Chris Rienzo ae69c5a7b0 FS-6407 --resolve mod_rayo: support SIP URI caller ID w/ display name 2014-04-15 14:27:49 -04:00
Raymond Chandler 052638186b add parsing of user params on invite 2014-04-15 12:48:07 -04:00
Nathan Neulinger 96523a9bef mod_skinny: fix leak 2014-04-14 15:04:06 -05:00
Nathan Neulinger 93a84cf130 FS-6460 --resolve fix leaked RTP ports that cause mod_skinny to fail after N calls 2014-04-14 13:23:05 -05:00
Chris Rienzo e8078d8aef mod_rayo: clean up module hashes on shutdown 2014-04-14 12:01:31 -04:00
Chris Rienzo b0c2c6d67c FS-6447 --resolve return subscriber-absent platform-code 20 if <dial> is attempted to user that is not registered 2014-04-14 09:47:41 -04:00
Peter Olsson 295964f0ec FS-6457 --resolve
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Travis Cross 2dba7dd367 Avoid leaking memory on mod_cdr_sqlite unload 2014-04-12 06:59:02 +00:00
Travis Cross 39f960a212 Avoid leaking memory on mod_voicemail unload 2014-04-12 06:48:36 +00:00
Travis Cross 886a730ae8 Avoid leaking memory on mod_hash unload 2014-04-12 06:43:11 +00:00
Travis Cross 237da22e22 Avoid leaking memory on unload of mod_dptools
Automated leak detectors find leaked memory on shutdown.  Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross 12af80d6b2 Condense styling a bit 2014-04-12 05:06:51 +00:00
Travis Cross 538cdd378c Hide warning about sometimes initialized variable
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
Travis Cross 3f8cf4a59d Fix memory leak in subscription handling
We were leaking one event (~539 bytes) for every subscribe packet
received with both an "event: as-feature-event" and an authorization
header.
2014-04-12 05:00:41 +00:00
James Le Cuirot 4bdb7129ba Ungetlib libmemcached
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.

FS-353
2014-04-11 22:55:36 +00:00
James Le Cuirot 23fe7f5c9f Add libyaml pkg-config LIBS to LIBADD not LDFLAGS
Per the automake manual these should go in LIBADD.

http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html

FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-04-11 22:53:14 +00:00
Anthony Minessale 38c6e89db0 remove SSML from mod_rss 2014-04-11 03:33:57 +05:00
Chris Rienzo a86623972d mod_rayo: fixed input crash introduced in 2014-04-07 commit 2014-04-10 10:20:47 -04:00
Anthony Minessale 4178688b4a add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc 2014-04-09 23:26:47 +05:00
Travis Cross 1e273e514d Avoid playback on dead channels in voicemail
For years we've been generating spurious messages like:

  [WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns

This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get().  Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.

The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone.  We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
Anthony Minessale 369bb55d15 remove unnecessary pool create 2014-04-09 03:18:21 +05:00
William King 711e49c46a Don't leak these 4 hash tables when mod_fifo is reloaded 2014-04-08 11:18:23 -07:00
William King aae1954c07 FS-6442 --resolve 2014-04-08 10:36:36 -07:00
Chris Rienzo 264a12a4af mod_rayo: fix memory corruption in dial, input, output 2014-04-07 12:37:39 -04:00