Commit Graph
22055 Commits
Author SHA1 Message Date
agree 767b163cbd [mod_sofia] Fix PRESENCE_PROBE firing on rejection
After rejecting the subscription for authentication the function calls goto end. In the end block freeswitch fires PRESENCE_PROBE events and releases the allocated memory
* when rejecting a call for auth PRESENCE_PROBE should not get fired
* This caused all other subscribers to the same entity to get flooded with NOTIFY's because `call_id` only gets set later in the function, so when firing the PRESENCE_PROBE without `call_id` being set all subscriptions will get a notify
* this can be considered a security flaw as any unauthorized user can send
SUBSCRIBES and trigger thousands of NOTIFY's to the SUBSCRIBED endpoints

This was fixed simply my moving down the end label after the code that
sends the PRESENCE_PROBE event
2022-08-26 18:09:34 -04:00
Andrey Volk 060a65601b [Core] Fix wrong switch_odbc_skip_autocommit_flip function declaration. 2022-08-26 21:47:45 +03:00
Andrey Volk 2b8f59e8ff Merge pull request #1773 from signalwire/autocommit
[Core] ODBC: Add odbc-skip-autocommit-flip switch param.
2022-08-26 20:21:23 +03:00
Andrey Volk 9f5c2a1619 [mod_sofia] Unit-test: Fix strcmp null argument. 2022-08-26 16:21:01 +03:00
Andrey Volk a1d2f83104 [Core] ODBC: Add odbc-skip-autocommit-flip switch param. 2022-08-25 20:14:47 +03:00
RuslanandRuslan Andronov a8dee4b2ff [mod_conference] file descriptor stays open
Solution: don't even start to play file if conference is not running.

Co-authored-by: Ruslan Andronov <randronov@outlook.com>
2022-08-23 18:07:55 +03:00
agree f538fd3d7b [mod_say_en] change epoch to 64 bit int
handle time after 2038-01-18 22:14:07
2022-08-21 01:16:36 -04:00
Andrey Volk 1e5e3216d8 [mod_conference] Fix dead nested assignments 2022-08-10 00:18:18 +03:00
Andrey Volk cd86de2f1f [mod_av] Fix dead nested assignments 2022-08-10 00:17:03 +03:00
Andrey Volk f3c7c4d445 [Core] scan-build: Fix false-positive bad free by switch_must_realloc() in switch_xml_proc_inst() 2022-08-10 00:15:45 +03:00
Andrey Volk 716a21b0b5 [mod_callcenter] Fix dead nested assignments in cc_config_api_function 2022-08-10 00:14:36 +03:00
Andrey Volk 19a7debc1b [mod_sofia] Fix dead nested assignments 2022-08-10 00:13:18 +03:00
Andrey Volk 884917cb11 [mod_xml_scgi] Fix dead initialization in mod_xml_scgi_shutdown() 2022-08-10 00:11:58 +03:00
Andrey Volk 1f9305098d [mod_xml_ldap] Fix potential memory leaks in xml_ldap_search() 2022-08-10 00:10:47 +03:00
Andrey Volk d38d83339d [mod_say_hr,hu,pl,sv] Fix dead nested assignments 2022-08-10 00:09:28 +03:00
Andrey Volk 1c83a92b7d [mod_video_filter] Fix dead nested assignments 2022-08-10 00:07:52 +03:00
Andrey Volk b6264e264c [mod_enum] Fix dead nested assignments 2022-08-10 00:03:52 +03:00
Andrey Volk 688984f8b9 [mod_dptools] Fix dead nested assignments. 2022-08-09 23:48:29 +03:00
Andrey Volk c062f85e16 [mod_commands] Fix dead nested assignments 2022-08-09 23:44:56 +03:00
Andrey Volk 6ef22a6f7d [mod_v8] Fix dead nested assignments 2022-08-09 23:35:13 +03:00
Andrey Volk 01844013a0 [mod_sofia] Fix potential memory leak in sofia_reg_handle_sip_r_challenge() 2022-08-09 23:33:21 +03:00
Andrey Volk 56b6e954cf [Core] Fix dead nested assignments 2022-08-09 23:29:31 +03:00
Andrey Volk c47c16b1dd Fix dead nested assignments in various modules 2022-08-09 23:20:52 +03:00
Dragos Oancea c9def5990e [core, mod_sofia] add some extra checks when creating the digest. 2022-08-08 18:56:09 +03:00
Andrey Volk d96b6a4a8f [Core] Fix possible race condition between locking a session and reading it's flags in switch_core_session_read_lock() and switch_core_session_read_lock_hangup(). 2022-07-26 01:49:31 +03:00
Andrey Volk c671ebcb88 [mod_sofia] unit-tests: Give mod_sofia time to spin up profile threads on load. Remove some fst_requires(). 2022-07-26 01:47:27 +03:00
Thiadmer 86ad85161b [mod_say_de] Let de_say_time handle short_date_time type 2022-07-11 10:21:34 +02:00
Dragos Oancea 871cc585b1 [mod_voicemail] fix vm_fsdb_msg_list 2022-07-06 15:26:43 +03:00
Dragos Oancea beffab1d68 [core] RTP: a media timeout fix + add pcap based-unit tests. 2022-06-29 18:20:27 +03:00
FusionPBX 75e858407f [mod_sofia] Add Fanvil to vendors allowed to update. 2022-06-16 18:00:09 +03:00
Dragos Oancea 92a336a07d [core] fix loglevel - switch_ivr_phrase_macro_event() 2022-06-08 13:25:35 +03:00
Andrey Volk a83e2f6b41 swigall 2022-06-07 19:38:29 +00:00
KenandKen Rice 3b65b1bedb [Core] Change values for switch_call_cause_t to avoid SIP causecode collissions
Update values for switch_call_cause_t in switch_types.h to avoid
sip cause code collisions that can affect continue_on_fail or
failure_causes channel variables when numeric SIP or ISUP cause codes
are used.

Co-authored-by: Ken Rice <krice@sipnavigator.com>
2022-06-07 21:45:55 +03:00
KenandBrian West 04df9c12f7 [mod_sofia] on call term optionally ignore Q.850 Reason
Currently SIP termination messages with Q.850 override the SIP
reason. Add chanvar ignore_q850_reason to ignore the Q.850 reason
and keep the SIP Reason Code.

Using the chan var avoids unexpected changes in behavior.

Co-authored-by: Brian West <brian@freeswitch.org>
2022-06-07 19:58:43 +03:00
Andrey Volk 1f055250e1 [mod_av] Remove unused buf variable in av_file_write 2022-05-23 22:34:29 +03:00
Andrey Volk 6b4359f4ae [mod_av] Avoid using 16384 stack (or heap) bytes in av_file_write(). Remove ff_input_buffer_padding static variable. 2022-05-23 22:00:45 +03:00
Andrey Volk aa161b9e58 [Core] Allow switch_buffer_write() to fill in a buffer with zeros. Add switch_buffer_zero_fill() 2022-05-23 21:51:26 +03:00
Andrey Volk 663ac586d1 Merge pull request #1510 from signalwire/PG_VERSION_NUM
[mod_pgsql] Fix build by using PG_VERSION_NUM provided by libpq instead of using POSTGRESQL_MAJOR_VERSION detected by freeswitch configure.
2022-05-19 23:30:31 +03:00
Andrey Volk f07a442682 [Core] Avoid using insecure sqlite3_enable_load_extension when SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION is available. 2022-05-18 23:54:01 +03:00
prabhugithubme 4886383e32 [Core] Fix switch_core_media_patch_sdp parsing m=text wrongly 2022-04-07 15:22:25 +03:00
Andrey Volk 70a1761ab5 Merge pull request #1424 from dhruvecosmob/test_tts_change
[mod_test] Increase tts_time unit-test's duration window.
2022-04-01 13:27:57 +03:00
Dragos Oancea 30d5d58e6e [core] fix set rtp flag for rtcp events after flags zeroed out. 2022-03-29 15:07:50 +03:00
Andrey Volk c17a5dbc59 Merge pull request #1577 from dragos-oancea/mod_local_stream-loc-fix
[mod_local_stream] fix path with ".loc" file extension.
2022-03-28 15:45:12 +03:00
Andrey Volk 0eed5046a0 Merge pull request #1595 from azzbcc/fix_memory_leak_in_asr_feed
[core] fix memory leak in switch_core_asr_feed
2022-03-26 14:05:25 +03:00
Aron Podrigal 0365becc0d [mod_sofia] Fix fs_path to keep <> so that sofia doesn't put the uri parameters as header parameters. Handle multiple Record-Route / Route and Path headers. 2022-03-25 19:44:25 +03:00
Clarence 3d283a989d [core] fix memory leak in switch_core_asr_feed 2022-03-23 17:05:50 +08:00
Dragos Oancea df81021a11 [core] make switch_core_media_prepare_codecs() more unit-test friendly. 2022-03-21 13:59:37 +03:00
agree 415a8a19eb [mod_callcenter] Fix globals.nodes gets unset
`globals` was getting initialized to null after `switch_event_bind_removable` binding causing `globals.nodes` to get set to NULL causing `switch_event_unbind` not to be able to unbind the SWITCH_EVENT_PRESENCE_PROBE event when unloading the module. Besides not being able to unbind the event, this was also causing a segfault  upon receiving a PRESENCE_PROBE event when unloading or reloading the module
2022-03-19 22:44:26 -04:00
Andrey Volk d01c427c0b [mod_conference] Fix regression made by previous commit when fixing memory consumption. 2022-03-18 01:53:38 +03:00
Dragos Oancea 24355b63ab [mod_local_stream] fix path with ".loc" file extension. 2022-03-15 18:47:06 +02:00