Commit Graph
3676 Commits
Author SHA1 Message Date
William King ad327dffc8 CID: 1211946 fixing uninitialized pointer read in mod_translate 2014-05-07 00:22:56 -07:00
Steve Underwood 38abcf7e2c The APIs for spandsp FAX have changes, removing one of the parameters passed in
the callbacks.
2014-05-04 17:22:28 +08:00
Michael Jerris 9db6d5ba9c different distros have diff pkg names 2014-05-02 18:35:37 -04:00
Natanael Copa 317f4b1442 Fix building with musl libc
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)

limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Travis Cross fc40e4ab79 Avoid leaking data_buf in mod_conference
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated.  On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Michael Jerris 582fa1a664 fix typo 2014-05-01 18:22:57 -04:00
Travis Cross cd650f6055 Use system ldns library
This library is used only by mod_enum and is available on most
platforms.  The version in our tree has many code quality problems
that are generating noise when doing static analysis.  Suffice it to
say we want rid of it as our responsibility.

FS-353
2014-05-01 22:01:59 +00:00
Travis Cross c1f884cd33 Remove old ldns patch from FS-3110 2014-05-01 22:01:59 +00:00
Raymond Chandler 33460064ac CID: 1210739 2014-05-01 17:34:54 -04:00
Raymond Chandler a4e0929ef0 CID: 1210596 2014-05-01 17:28:54 -04:00
Raymond Chandler 17f79bc2c3 CID: 1210770 2014-05-01 16:36:58 -04:00
Anthony Minessale 7f18b80e60 FS-6503 --resolve remove unused code 2014-05-02 01:28:12 +05:00
Brian West c462ed6ae1 FS-6499 --resolve 2014-05-01 15:21:57 -05:00
Michael Jerris 64f1098b8c remove dead assignment 2014-05-01 14:17:06 -04:00
Michael Jerris b0fd845786 remove dead assignment 2014-05-01 14:04:56 -04:00
Raymond Chandler e4d807108c CID: 1210646 2014-04-30 18:47:02 -04:00
Raymond Chandler 3abcee7142 unused 2014-04-30 18:36:44 -04:00
Michael Jerris 23b3e172d5 don't leak file handle if fd = 0 2014-04-30 15:56:36 -04:00
Michael Jerris 6f16e0d3da don't leak if first realloc fails but second one succeeds 2014-04-30 15:53:26 -04:00
Michael Jerris 068ad205b7 split this into 2 functions so its clear if this function allocates or not 2014-04-30 15:48:23 -04:00
Michael Jerris 0b8d2c5d65 add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr 2014-04-30 13:31:06 -04:00
Michael Jerris a9a852477a fix read beyond buffer length error 2014-04-30 13:25:29 -04:00
Chris Rienzo c36e63026c mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL) 2014-04-30 10:08:00 -04:00
Michael Jerris e98045841e gracefully handle allocation failure 2014-04-30 08:55:39 -04:00
Michael Jerris 2e8572acb5 we always have the session in the dialplan function 2014-04-30 08:51:52 -04:00
Michael Jerris b3bfa563ae we always have the caller profile at this point, if for some reason we don't just instead of crashing 2014-04-30 08:50:29 -04:00
Michael Jerris 7508481597 we always have the seesion in the app function 2014-04-30 08:46:11 -04:00
Michael Jerris 9bf98d0dd3 remove useless checks of array == 0 2014-04-30 08:43:57 -04:00
Michael Jerris 529099f15c silence incorrect warnings about null pointer derference and remove unused code 2014-04-29 14:34:49 -04:00
Brian West 5c07c3eb03 don't use memory after free when using naptr with mod_enum with multiple routes 2014-04-28 13:03:09 -05:00
Michael Jerris a83fde3543 block of code in here twice was writing over expanded, causing it to potentially leak 2014-04-28 13:41:48 -04:00
Brian West 1aa2fc7548 FS-3332 --resolve 2014-04-25 15:53:21 -05:00
Anthony Minessale 2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Brian West 265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West 190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
William King 748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Travis Cross 39f960a212 Avoid leaking memory on mod_voicemail unload 2014-04-12 06:48:36 +00:00
Travis Cross 886a730ae8 Avoid leaking memory on mod_hash unload 2014-04-12 06:43:11 +00:00
Travis Cross 237da22e22 Avoid leaking memory on unload of mod_dptools
Automated leak detectors find leaked memory on shutdown.  Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross 538cdd378c Hide warning about sometimes initialized variable
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
James Le Cuirot 4bdb7129ba Ungetlib libmemcached
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.

FS-353
2014-04-11 22:55:36 +00:00
Anthony Minessale 38c6e89db0 remove SSML from mod_rss 2014-04-11 03:33:57 +05:00
Anthony Minessale 4178688b4a add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc 2014-04-09 23:26:47 +05:00
Travis Cross 1e273e514d Avoid playback on dead channels in voicemail
For years we've been generating spurious messages like:

  [WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns

This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get().  Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.

The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone.  We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
William King 711e49c46a Don't leak these 4 hash tables when mod_fifo is reloaded 2014-04-08 11:18:23 -07:00
William King aae1954c07 FS-6442 --resolve 2014-04-08 10:36:36 -07:00
Anthony Minessale c98fb0bd0e send muted members as recvonly on RFC4575 data 2014-04-07 20:51:29 +05:00
Anthony Minessale 1ce92b3ae7 FS-6421 --resolve 2014-04-02 16:43:36 -05:00
Anthony Minessale 7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00