Commit Graph

267 Commits

Author SHA1 Message Date
Travis Cross 9b9bc8b796 Fix minor edge case in switch_split_user_domain
If the input started with 'sip:sips:' it would have been incorrectly
parsed.
2014-03-06 06:05:16 +00:00
Travis Cross 5d706aa4fc Optimize switch_split_user_domain a bit
This avoids searching the string repeatedly with strchr.
2014-03-02 09:49:21 +00:00
Travis Cross 1060a188ce Refactor and fix edge cases in switch_split_user_domain
We were incorrectly parsing usernames and domains starting with "sip"
if there was no sip: or sips: scheme in the string.

We were also incorrectly parsing usernames containing a colon even if
a scheme was given.

This also refactors the function for hopefully greater clarity.
2014-03-02 09:29:23 +00:00
Travis Cross 2dcac7d350 Fix switch_split_user_domain handling of sips: URLs
In commit 7efeabbd88 Anthony fixed the
handling of sip:example.com and sips:example.com URLs, however he
introduced a regression causing URLs starting with 's' to be parsed
incorrectly.

In commit 7d2456ea27 Brian fixed the
regression, but introduced a regression causing sips:example.com URLs
to be handled incorrectly.
2014-03-02 08:12:33 +00:00
Brian West e8c163c1ee FS-6250 fix regression from 7efeabbd88, don't discrimiate against people that have s as the first character in their user names 2014-02-27 02:27:39 +05:00
Anthony Minessale b35196f78e fix switch_split_user_domain to parse sip:foo.com properly 2014-02-12 23:11:54 +05:00
Anthony Minessale 93c7e496c7 FS-5708 --resolve 2013-08-19 23:48:38 +05:00
Ken Rice 8566ffa82a Revert FS-5708 ; build issues
This reverts commit 77d0ee21b2.
2013-08-16 17:54:03 -05:00
Anthony Minessale 2449371329 FS-5709 --resolve 2013-08-17 02:16:38 +05:00
Anthony Minessale 77d0ee21b2 FS-5708 --resolve 2013-08-17 02:14:19 +05:00
Nathan Neulinger 543dc3caea make noexpandtab explicit in all vim modelines other than xml files
Conflicts:
	src/include/switch_core_media.h
	src/mod/endpoints/mod_sofia/sofia_media.c
	src/switch_core_media.c
2013-06-25 09:39:37 -05:00
Jeff Lenk 6000c884aa windows fix trivial compiler warning 2013-06-07 05:42:43 +00:00
Nathan Neulinger fc39b77520 FS-5449: apply correct quoting, got older version of patch accidentally 2013-05-31 16:40:17 -05:00
Nathan Neulinger 634a507546 FS-5449: --resolve add a mod_commands function to use the shell escape function and update the existing function to use correct escaping
adds a pool based implementation of the switch_util_quote_shell_arg function and changes existing function to be a wrapper around the pool based one
2013-05-31 16:40:10 -05:00
Travis Cross a744b202fd Quote arguments to shell when sending email
Note that the function switch_util_quote_shell_arg is implemented
incorrectly for unix shells, so this is still not safe until that
function is fixed.

Reported-by: Nathan Neulinger <nneul@mst.edu>

FS-5450 --resolve
2013-05-26 01:41:02 +00:00
Travis Cross 103d97e208 Leave room for switch_escape_string to add a terminating null
Thanks-to: Nathan Neulinger <nneul@mst.edu>

FS-5448 --resolve
2013-05-25 23:29:48 +00:00
William King 782480c48b Better to not pass tmp_socket to setsockopt if there was an error here creating the socket. 2013-05-25 07:36:43 -07:00
Anthony Minessale aed693b9e5 FS-5436 --resolve 2013-05-21 19:39:21 -05:00
William King 48f423db40 This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated. 2013-05-18 13:39:12 -07:00
Anthony Minessale abdc4bf091 add some more mime types for wav and mp3 2013-03-15 20:34:24 -05:00
Anthony Minessale 17b9f68f80 add better tolower to go with the toupper 2013-01-08 14:21:41 -06:00
Anthony Minessale 5d35d71cfd FS-4928 doing 100 calls I found 7 million calls to toupper, this patch replaces it with an inline optimized one I found online. Not sure it helps but maybe you can profile it again with latest. 2012-12-11 19:18:25 -06:00
Jeff Lenk 27c236a03a FS-4847 test again 2012-11-21 09:41:14 -06:00
Jeff Lenk 2ee8058488 FS-4847 try this 2012-11-20 16:54:35 -06:00
Jeff Lenk 9015b20f32 FS-4847 try this too 2012-11-19 16:28:39 -06:00
Jeff Lenk 21b9ec8868 FS-4847 --resolve 2012-11-19 16:23:55 -06:00
Anthony Minessale c5204c2128 FS-4614 --resolve update to dynamic line buffer and use internal buffering to boot for file I/O on preprocessing XML 2012-09-18 15:39:28 -05:00
Anthony Minessale 455b22480c FS-3971 --resolve 2012-09-04 12:30:23 -05:00
Stefan Knoblich eca5c0ad73 FreeSWITCH: Add WIN32 strerror_s() variant to custom switch_strerror_r() helper function and fix more strerror_r() users.
Convert mod_xml_cdr, mod_json_cdr and mod_conference to the new function.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2012-08-14 14:54:06 +02:00
Stefan Knoblich 8bcf3b4fb8 FreeSWITCH: Add switch_strerror_r() to fix problems with XSI and GNU variants of strerror_r().
GNU variant of strerror_r() returns char *, while the XSI version returns int.

To make things worse, glibc ships both and added a unused result warning
in recent versions (2.16) causing the build to fail.

Add our own custom wrapper that always returns a pointer to the message buffer
and additionally make XSI versions of strerror_r() GNU compatible by
returning "Unknown error xxx" if no error message is available.

Fixes:
    src/switch_rtp.c: In function 'rtp_common_read':
    src/switch_rtp.c:3313:15: error: ignoring return value of 'strerror_r',
    declared with attribute warn_unused_result [-Werror=unused-result]
    cc1: all warnings being treated as errors

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2012-08-14 14:11:44 +02:00
Anthony Minessale e81d31ce43 FS-4429 --resolve you guys should come to cluecon we would like to help you get bvtapi working really well 2012-07-16 13:39:23 -05:00
Ken Rice c5554eb939 Copyright date update. 2012-04-18 11:52:02 -05:00
Anthony Minessale e31389ac9c FS-4097 --resolve 2012-04-10 08:05:09 -05:00
Anthony Minessale 3ca8536558 regression from 29f66f99 2012-02-23 16:21:14 -06:00
Anthony Minessale 29f66f994c doh 2012-01-27 14:18:19 -06:00
Anthony Minessale 7471ec17ed add printed errors to mailer part 2 2012-01-27 13:52:15 -06:00
Anthony Minessale 0b21064a05 add printed errors to mailer 2012-01-27 13:41:50 -06:00
Anthony Minessale b8fdbc4860 FS-3808 --resove We audited for this, must have overlooked this one, thanks. 2012-01-11 21:33:23 -06:00
Jeff Lenk 24288832b1 FS-2216 partial with renaming 2012-01-08 14:19:16 -06:00
Jeff Lenk 79992ac5fe refactor switch_fulldate_cmp and correct usec comparison and year month error 2012-01-01 22:40:23 -06:00
Jeff Lenk 26a49a6e70 FS-3753 --resolve 2011-12-11 22:15:55 -06:00
Jeff Lenk 422df6180f trivial fix build 2011-11-21 12:50:00 -06:00
Michael Jerris d66d41232b don't format non numbers 2011-11-21 13:31:19 -05:00
Anthony Minessale 94b9cc0f9f add voicemail_formatted_caller_id_number param for templates in vm 2011-11-10 14:39:28 -06:00
Anthony Minessale 1c60b9946f d'oh you'll want to update 2011-11-04 14:26:39 -05:00
Anthony Minessale 0ed54079e4 FS-3663 --resolve 2011-11-04 13:16:54 -05:00
Anthony Minessale 1bf97fa7ba add some more reporting data to logs 2011-10-11 15:13:23 -05:00
Michael Jerris 61dd9c0765 don't delete file if its the same file 2011-09-15 10:48:37 -04:00
Anthony Minessale b4b99c410d do not escape strings inside single quotes unless we can find a closing quote too 2011-09-13 16:50:05 -05:00
Anthony Minessale dd6996cd3f revert 2011-09-12 14:25:01 -05:00