Commit Graph

10676 Commits

Author SHA1 Message Date
Nathan Neulinger da5c2a6aef FS-5225: --resolve add ability to dial by pressing line button 2013-05-31 15:10:43 -05:00
Nathan Neulinger c33eb7412b FS-5267: --resolve avoid null deref if sessions missing 2013-05-31 15:10:43 -05:00
Mathieu Parent ab7635e9bc Add IPs to mod_skinny recv/send event messages
FS-5268 --resolve
thanks to Nathan Neulinger
2013-05-31 15:10:43 -05:00
Mathieu Parent 4a981b336a Don't pretend we support skinny-wait timeout (See #FS 477) 2013-05-31 15:10:42 -05:00
Mathieu Parent b36ad82da7 Don't create a new session when pressing speeddial
Fixes #FS-5259 (Thanks to Nathan Neulinger for the patch)
2013-05-31 15:10:42 -05:00
Brian West 83c6f4250b add kirk wireless servers to safe as they do not do rport 2013-05-31 11:56:53 -05:00
Steve Underwood 4d08e07237 Fixed a weakness in error UDPTL lost packet recovery. Hopefully this addresses
FS5202.
2013-05-31 09:04:46 -05:00
Brian West b90dee2461 Swap this 2013-05-31 09:16:50 -05:00
Travis Cross e1a773406d Unsigned values are never less than zero 2013-05-29 03:02:21 +00:00
Travis Cross 1637a08206 Avoid using psession uninitialized in mod_fsk 2013-05-29 03:00:13 +00:00
Travis Cross de3727fe06 Add common include paths for jni.h and jni_md.h 2013-05-29 02:48:28 +00:00
Travis Cross 50a02efd27 Fix variable type in mod_nibblebill 2013-05-29 02:48:11 +00:00
Travis Cross e964215868 Work around error in pocketsphinx-0.7
fsg_search.c:263:2: error: non-void function 'fsg_search_reinit' should return a value [-Wreturn-type]
2013-05-29 02:48:01 +00:00
Travis Cross e60877cde6 Add missing newline at end of mod_say_fa.c 2013-05-29 02:47:08 +00:00
Mariusz Czułada cd549aa44a FS-5157 patch accepted 2013-05-29 00:22:19 +02:00
Travis Cross acc8eb5cb6 Remove unused variable in mod_rtmp
Unused variables break the build with recent versions of gcc and
clang.
2013-05-26 05:29:21 +00:00
Travis Cross ff85c6cfdf Fix memory leaks in mod_tts_commandline
We were using both switch_util_quote_shell_arg and
switch_string_replace without freeing the results even though both
functions malloc.
2013-05-26 01:08:10 +00:00
Travis Cross 103d97e208 Leave room for switch_escape_string to add a terminating null
Thanks-to: Nathan Neulinger <nneul@mst.edu>

FS-5448 --resolve
2013-05-25 23:29:48 +00:00
Travis Cross 2870bb9200 Fix comment spelling
Thanks-to: Mariusz Czułada <manieq.net@gmail.com>
2013-05-25 21:47:08 +00:00
Travis Cross ed276a10d2 Fix memory corruption in mod_erlang_event
Thanks-to: Alexandre Snarskii <snar@snar.spb.ru>

FS-5465 --resolve
2013-05-25 21:46:58 +00:00
William King a4b8226c89 Cleaning up logically dead code. 2013-05-25 07:02:33 -07:00
William King 50b664c2dd Small off by one error. If the array is of size 144, then an index of 144 inclusive is an error. 2013-05-25 06:41:22 -07:00
William King dfbc175776 Let's bit a bit safer when dereferencing pointers. 2013-05-24 20:03:19 -07:00
William King 6c3062a768 Removing logically dead code 2013-05-24 19:59:20 -07:00
William King 4edf66be98 If there is a problem reading the dictionary file, don't leak memory... 2013-05-24 19:55:37 -07:00
William King 8803804f90 Removing unused code 2013-05-24 19:53:10 -07:00
William King 47c6981a9f More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL. 2013-05-24 19:49:20 -07:00
William King 6320042f6b Another location where mod_rtmp would leak memory. 2013-05-24 19:45:24 -07:00
William King 83ae82fd2d Fix improper handling of a double linked list that could have caused a memory leak. 2013-05-24 19:42:02 -07:00
William King b3aea78730 Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node. 2013-05-24 19:35:43 -07:00
William King 8a743cb2f3 Fixing a memory leak. name needs to be freed since it's being strdup'd lower. 2013-05-24 19:31:40 -07:00
Anthony Minessale aecd186ba5 FS-5470 --resolve 2013-05-24 09:37:40 -05:00
Mariusz Czułada e44316d3ea FS-5042 changed event body creation 2013-05-24 09:02:23 -05:00
Anthony Minessale 22076b7b6f FS-5453 --resolve 2013-05-24 08:13:55 -05:00
Anthony Minessale 9c98829aab FS-5453 --resolve this is a different issue, we just have to hangup the loopback channel so the loopback and the sip don't both execute the extension 2013-05-23 09:59:18 -05:00
Anthony Minessale 0060313ea1 swig 2013-05-23 09:55:52 -05:00
Anthony Minessale 18ac2a2540 FS-5042 --resolve 2013-05-23 08:07:26 -05:00
Anthony Minessale 3d2eb20a28 FS-5453 --resolve 2013-05-23 08:06:52 -05:00
Anthony Minessale c08622235d FS-5402 --resolve the problem is ent originate has many channels and many causes to parse so we need to check it against all the causes 2013-05-22 11:01:59 -05:00
Anthony Minessale 1b6860d8e3 FS-5453 --resolve 2013-05-21 12:02:12 -05:00
Anthony Minessale e2da2e19c3 FS-5376 --resolve 2013-05-21 10:04:58 -05:00
Anthony Minessale fb3eb97568 FS-5242 2013-05-21 10:03:36 -05:00
Anthony Minessale 4bdd2a7f84 FS-5211 --resolve 2013-05-21 09:30:06 -05:00
William King 79e3de3e55 full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors. 2013-05-18 19:13:44 -07:00
William King c80d768004 My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer. 2013-05-18 17:46:50 -07:00
William King f3393ef362 Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case. 2013-05-18 17:35:07 -07:00
William King bd4ea84242 Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak. 2013-05-18 17:07:31 -07:00
William King 97286e10cd Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up. 2013-05-18 17:01:27 -07:00
William King 14f48a6a7a Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not. 2013-05-18 16:36:41 -07:00
William King d61d395e8d If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done. 2013-05-18 16:06:15 -07:00