Travis Cross
edecd151a5
mod_fifo: Document the read_frame_callbacks
2014-05-28 01:32:06 +00:00
Travis Cross
42ebfbfc59
mod_fifo: Document the fifo_queue_t structure
2014-05-28 01:32:06 +00:00
Travis Cross
5f4ed9c123
mod_fifo: Document fifo_chime_data::list
2014-05-28 01:32:05 +00:00
Travis Cross
2c7c15261d
mod_fifo: Document caller DTMF handler
2014-05-28 01:32:05 +00:00
Travis Cross
3e6199eace
mod_fifo: Remove reimplementation of strchr()
2014-05-28 01:32:05 +00:00
Travis Cross
27b3ddcc9f
mod_fifo: Document the consumer DTMF callback
2014-05-28 01:32:04 +00:00
Travis Cross
7920630c8f
mod_fifo: Refactor DTMF exit key matching
2014-05-28 01:32:04 +00:00
Travis Cross
c34ad2c0ec
mod_fifo: Avoid getting a var when we won't use it
2014-05-28 01:32:04 +00:00
Travis Cross
077579b131
mod_fifo: Document fifo_queue_popfly()
2014-05-28 01:32:03 +00:00
Travis Cross
b914c2374d
mod_fifo: Document fifo_queue_pop_nameval()
2014-05-28 01:32:03 +00:00
Travis Cross
1eaf4b50ca
mod_fifo: Document remove parameter of fifo_queue_pop()
2014-05-28 01:32:03 +00:00
Travis Cross
e241477860
mod_fifo: Tighten up some whitespace
2014-05-28 01:32:03 +00:00
Travis Cross
e677da5870
mod_fifo: Refactor in create_node()
2014-05-28 01:32:02 +00:00
Travis Cross
628b6c19ab
mod_fifo: Remove dead code
...
We were making a copy of the fifo name and stripping any domain name,
but then not using the value.
2014-05-28 01:32:02 +00:00
Travis Cross
6105e9783c
mod_fifo: Refactor load_config()
...
Reduce number of local variables where possible; consolidate lines.
2014-05-28 01:32:02 +00:00
Travis Cross
353c3b19fa
mod_fifo: Document fifo_node::outbound_name
2014-05-28 01:32:01 +00:00
Travis Cross
17070e9dac
mod_fifo: Improve strategy thread function names
2014-05-28 01:32:01 +00:00
Travis Cross
1f7589d6fa
mod_fifo: Refactor
2014-05-28 01:32:01 +00:00
Travis Cross
0526e00457
mod_fifo: Replace global var with local static
...
This marker value is only used in one place.
2014-05-28 01:32:01 +00:00
Travis Cross
2068b284cc
mod_fifo: Fix memory leak of xml structure
...
If getting the DB handle failed during the load or reload of the
configuration, we would leak the XML structure we just allocated for
the configuration.
2014-05-28 01:32:00 +00:00
Travis Cross
c6e90e0111
mod_fifo: Refactor out config file reading
2014-05-28 01:32:00 +00:00
Travis Cross
a3a62d2481
mod_fifo: Convert macro to fn and improve name
2014-05-28 01:32:00 +00:00
Travis Cross
06d94d2c17
mod_fifo: Move straggling vars to global struct
2014-05-28 01:31:59 +00:00
Travis Cross
31ae5b4655
mod_fifo: Cleanup whitespace
2014-05-28 01:31:59 +00:00
Travis Cross
f80e869fe0
mod_fifo: Cleanup whitespace in load_config()
2014-05-28 01:31:59 +00:00
Travis Cross
a15058406e
mod_fifo: Cleanup config parsing
2014-05-28 01:31:58 +00:00
Travis Cross
20f35e4591
mod_fifo: Improve function names
2014-05-28 01:31:58 +00:00
Travis Cross
84d6b2e351
mod_fifo: Consolidate code
2014-05-28 01:31:58 +00:00
Travis Cross
8ccd13bd9a
mod_fifo: Document load_config()
2014-05-28 01:31:58 +00:00
Travis Cross
83f69a41e8
Add in-code documentation for mod_fifo
...
The goal here is to describe theory. We want to illuminate what the
code is trying to do and what the core concepts are.
2014-05-28 01:31:57 +00:00
Michael Jerris
c768e4b6e6
CID:1215198 don't set variables that are not used, and clean up the bail out usage condition to be more sane
2014-05-22 14:52:56 +00:00
William King
11f373d4f2
CID: 1215198 Fix an assignment so that the variable only handles malloc'd data.
2014-05-21 16:28:03 -07:00
Marc Olivier Chouinard
29e2263442
CID:1210789 Make return value of a function available from the another calling function. Also add a small status check.
2014-05-16 17:18:17 -04:00
Marc Olivier Chouinard
8fa7398760
CID:1025868 Simplified a function arguments never called.
2014-05-16 17:03:59 -04:00
Michael Jerris
386000d877
CID:1024418 Unintentional integer overflow
2014-05-16 20:07:58 +00:00
Michael Jerris
4238339176
CID:1023970 Unused pointer value
2014-05-16 19:53:23 +00:00
Michael Jerris
6a8002db79
CID:1024582 Logically dead code
2014-05-16 19:27:25 +00:00
Michael Jerris
21a5d166c6
CID:1024581 Logically dead code
2014-05-16 19:22:37 +00:00
Michael Jerris
c1f7887039
CID:1024580 Logically dead code, x will always be > 1
2014-05-16 19:19:31 +00:00
Michael Jerris
73c1e09269
CID:1024579 Logically dead code
2014-05-16 19:09:18 +00:00
Michael Jerris
9b1ebff8de
CID:1024270 Dereference before null check
2014-05-16 18:54:50 +00:00
Michael Jerris
54fc2f5e39
CID:1023975 Unused pointer value
2014-05-16 18:49:23 +00:00
Michael Jerris
a67389ad5c
CID:1025879 Logically dead code
2014-05-16 18:20:25 +00:00
Michael Jerris
ecde431730
CID:1025850 Dereference before null check
2014-05-16 18:15:34 +00:00
Michael Jerris
b10c865c25
CID:1025849 Dereference before null check
2014-05-16 18:12:28 +00:00
Marc Olivier Chouinard
a997331577
CID:1214125 https://scan6.coverity.com:8443/docs/en/cov_checker_ref.html#static_checker_BUFFER_SIZE
2014-05-16 13:30:27 -04:00
Michael Jerris
1b0bdaf85e
CID:1214212 Resource leak in voicemail_list
2014-05-15 14:11:39 +00:00
Michael Jerris
4e888a282c
CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing
2014-05-15 14:09:38 +00:00
Michael Jerris
d2884ac5a6
CID:1214211 Resource leak
2014-05-15 13:58:08 +00:00
Michael Jerris
0469db0305
CID:1214200 Dereference null return value
2014-05-15 13:47:24 +00:00
Travis Cross