Commit Graph
126 Commits
Author SHA1 Message Date
Andrey Volk f0da2f2cd4 FS-11903: Fix errors reported by PVS-Studio Static Code Analyzer for libs/esl 2019-07-18 21:27:04 +04:00
Chris Rienzo ca8fa0e1ff FS-11785 [esl] dead assignments in esl_event_serialize
null attribute in esl_buffer_read
	       null attribute in esl_event_base_add_header
	       null attribute in esl_recv_event
2019-07-17 20:22:11 +04:00
Andrey Volk a7477ed0e2 FS-11911: Fix build on Debian Buster 2019-07-15 22:23:25 +04:00
Anthony Minessale bb7013817b FS-11138: [freeswitch-core] Leak in ESL client #resolve 2018-07-24 07:21:51 +00:00
Anthony Minessale d961aad2c2 FS-7604 #resolve 2015-06-02 13:17:04 -05:00
Travis Cross 2b1ae831d1 Remove some dead assignments in ESL 2014-05-02 03:57:07 +00:00
Michael Jerris a1a397420e fix leaked body in error case 2014-04-30 16:10:08 -04:00
Michael Jerris ba6b9c5a11 ESL-91: --resolve bigger buffer for args 2014-04-21 13:33:47 -04:00
Travis Cross f754057c2a Avoid crash on event without content-type
If we received an event without a content-type header we were
dereferencing a null pointer leading to a seg fault.

Reported-by: Ico <ico@voip-io.org>

ESL-90 --resolve
2014-04-09 01:20:07 +00:00
William King 138224d816 FS-6303 --resolve 2014-03-04 12:30:14 -08:00
Marc Olivier Chouinard 289d0de371 some circonstance, esl connection closing would hang. This should fix it 2014-02-23 20:52:14 -05:00
William King 5fb660933d ESL-82 --resolve
Previously any esl_connect_timeout() failures would not return to the calling application the reason for the failure.
This commit now allows for calling applications to know why the connection attempt fails, but it is now the calling
applications responsiblity to call esl_disconnect() on the esl handle after the failure. Failing to call disconnect after
a failed connection attempt would result in memory being leaked.
2014-02-21 14:14:05 -08:00
Seven Du 11dee76381 add user_data in esl_listen so the main function can pass a private user_data to callback 2014-02-16 08:14:44 +08:00
Ken Rice 6e7d5d0897 update copyright header for 2014 2014-02-12 12:08:56 -06:00
Moises Silva f5f4df3483 Fix ESL infinite loop on handle_recv() when errno is already set
system calls do not clear errno, just set it in case of failure, so we
gotta make sure the recv() syscall really failed by checking the return value
2014-02-01 01:40:29 +05:00
Anthony Minessale ca8f121977 fix regression from recent refactor that causes infinite loop on unexpected disconnect 2013-11-22 04:53:34 +05:00
Anthony Minessale 634d936a02 kill socket in esl_disconnect to prevent blocking 2013-11-20 23:50:15 +05:00
Jeff Lenk 4ee3b70496 fix windows esl compile 2013-11-13 17:59:52 -06:00
Anthony Minessale c429de4139 fix build err 2013-11-14 01:38:00 +05:00
Anthony Minessale c469e7ada2 cleanup ESL a little 2013-11-14 00:43:25 +05:00
Anthony Minessale 931d3fb86a remove condition for mem leak 2013-11-12 12:33:32 -06:00
Nathan Neulinger 32adc789f6 make noexpandtab explicit in all vim modelines other than xml files 2013-06-25 11:50:17 -05:00
Travis Cross 3217442d0e Remove assignment without effect 2013-05-28 03:46:53 +00:00
Travis Cross 8c37db140e Handle a failure of strerror_r
This fixes the build on gcc-4.7.3.  The build was breaking with:

  error: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Werror=unused-result]
2013-05-25 19:05:34 +00:00
Travis Cross 6d5018007b Add missing text editor local variable blocks 2013-05-25 19:05:34 +00:00
Stefan Knoblich cb9090dc93 esl: Don't abort the esl_listen() loop(s) if accept() returns with errno == EINTR
ivrd doesn't use sigaction + SA_RESTART for SIGCHILD. An exiting
child process will interrupt accept() in the parent to handle
the signal, which makes accept() return -1 (errno = EINTR) after
the sighandler function returns.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-23 02:07:55 +02:00
Jeff Lenk dc2c11f13f FS-4768 initial add of vs2012 build support 2012-12-29 14:57:15 -06:00
Jeff Lenk c7e8dce247 FS-4828 --resolve 2012-11-17 21:38:07 -06:00
Ken Rice 3c249b012e FS-4003 --resolve add IPv6 support to ESL client library, thanks to Steven Ayre 2012-11-01 22:39:16 +00:00
Anthony Minessale 7d38669801 fix wrong len in ESL sendMSG method 2012-08-28 12:04:50 -05:00
Anthony Minessale 163fffb3e8 fix issue with threaded ivrd, forking is back by default but threaded can be chosen with -t; in both modes the fd number is not passed as the first arg to the program but in threaded mode the stdin will no longer be mapped to the socket you will have to get the first command line arg instead of fileno stdin 2012-05-03 13:13:48 -05:00
Ken Rice 7a147e4762 Update a ton of copyright statements to make sure the dates are proper 2012-04-25 17:14:55 -05:00
Anthony Minessale a40f304990 ESL-45 --resolve 2012-04-10 16:11:36 -05:00
Anthony Minessale c41a16d4da shutdown socket before closing to avoid blocking 2012-04-05 14:28:01 -05:00
Jeff Lenk da36d1f57f FS-3953 --resolve 2012-02-28 08:38:45 -06:00
Anthony Minessale 23645b6af2 comment assert for windows 2012-02-27 16:49:12 -06:00
Stefan Knoblich cc083ccddb [libesl] Make sure esl event buffer array subscript ist within bounds [0, sizeof(buffer)-1].
cc1: warnings being treated as errors
  libs/esl/src/esl.c: In function "esl_recv_event":
  libs/esl/src/esl.c:1190: error: array subscript is above array bounds
  libs/esl/src/esl.c:1227: error: array subscript is above array bounds

Clamp handle_recv() return value to safe values.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2011-12-19 20:39:51 +01:00
Marc Olivier Chouinard 442f4d2522 FS-3766 --resolve 2011-12-16 07:35:05 -05:00
Marc Olivier Chouinard 58ccbe567c ESL-58 --resolve
Please Windows user test this one out.
2011-12-15 23:02:10 -05:00
Anthony Minessale d05dcaaade ok, windows... you missed the real err but you are still crying about this other one =/ 2011-12-14 14:47:51 -06:00
Anthony Minessale 70a4ebd3fb sorry windows... 2011-12-14 14:38:00 -06:00
Anthony Minessale f7f9a43a40 use threading in testserver and ivrd 2011-12-14 12:16:09 -06:00
Jeff Lenk 482b319512 FS-3544 --resolve 2011-09-06 21:27:13 -05:00
Anthony Minessale 1c775c3bf0 finish up last commit 2011-09-06 15:07:51 -05:00
Anthony Minessale 2ae688a33b add sendmsg function to esl 2011-09-06 14:53:38 -05:00
Anthony Minessale c080fb15d9 update on array patch 2011-05-26 10:00:06 -05:00
Mathieu Rene ea38df0aed missed one 2011-05-26 10:52:41 -04:00
Jeff Lenk 55c24567bd fix windows code analysis problems 2011-05-25 23:51:48 -05:00
Anthony Minessale c1c759526d add arrays to event headers and chanvars 2011-05-25 15:42:36 -05:00
Anthony Minessale 73279f01bf FS-3166 --resolve 2011-04-22 16:43:29 -05:00