Commit Graph

  • 8803804f90 Removing unused code William King 2013-05-24 19:53:10 -07:00
  • 47c6981a9f More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL. William King 2013-05-24 19:49:20 -07:00
  • 6320042f6b Another location where mod_rtmp would leak memory. William King 2013-05-24 19:45:24 -07:00
  • 83ae82fd2d Fix improper handling of a double linked list that could have caused a memory leak. William King 2013-05-24 19:42:02 -07:00
  • b3aea78730 Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node. William King 2013-05-24 19:35:43 -07:00
  • 8a743cb2f3 Fixing a memory leak. name needs to be freed since it's being strdup'd lower. William King 2013-05-24 19:30:57 -07:00
  • aecd186ba5 FS-5470 --resolve Anthony Minessale 2013-05-24 09:37:25 -05:00
  • dc13cb847f FS-5466 --resolve Anthony Minessale 2013-05-24 09:14:13 -05:00
  • e44316d3ea FS-5042 changed event body creation Mariusz Czułada 2013-05-24 12:18:00 +02:00
  • d00ed860a1 FS-4871: reduce logging a bit Raymond Chandler 2013-05-23 20:51:25 -04:00
  • 4b54ec078b FS-5389 Jeff Lenk 2013-05-08 11:36:13 -05:00
  • b214af4ccf FS-5389 --resolve Jeff Lenk 2013-05-08 08:37:10 -05:00
  • 1e6d7ea113 FS-4871 --resolve Raymond Chandler 2013-05-07 15:07:04 -04:00
  • 22076b7b6f FS-5453 --resolve Anthony Minessale 2013-05-24 08:13:41 -05:00
  • 9c98829aab FS-5453 --resolve this is a different issue, we just have to hangup the loopback channel so the loopback and the sip don't both execute the extension Anthony Minessale 2013-05-23 09:59:00 -05:00
  • 0060313ea1 swig Anthony Minessale 2013-05-23 09:55:52 -05:00
  • 18ac2a2540 FS-5042 --resolve Anthony Minessale 2013-05-23 08:07:10 -05:00
  • 3d2eb20a28 FS-5453 --resolve Anthony Minessale 2013-05-23 08:00:03 -05:00
  • c08622235d FS-5402 --resolve the problem is ent originate has many channels and many causes to parse so we need to check it against all the causes Anthony Minessale 2013-05-22 11:01:39 -05:00
  • 666ba36e57 FS-5360 change defaults Anthony Minessale 2013-05-22 10:20:29 -05:00
  • aed693b9e5 FS-5436 --resolve Anthony Minessale 2013-05-21 19:39:02 -05:00
  • b73e2c51bb FS-5402 revert wait till tomorrow Anthony Minessale 2013-05-21 13:29:05 -05:00
  • b6561f2535 FS-5402 Anthony Minessale 2013-05-21 13:22:17 -05:00
  • 1b6860d8e3 FS-5453 --resolve Anthony Minessale 2013-05-21 12:01:57 -05:00
  • e4f7fda044 FS-5457 Anthony Minessale 2013-05-21 10:21:45 -05:00
  • e2da2e19c3 FS-5376 --resolve Anthony Minessale 2013-05-21 10:04:35 -05:00
  • fb3eb97568 FS-5242 Anthony Minessale 2013-05-21 10:03:22 -05:00
  • 4bdd2a7f84 FS-5211 --resolve Anthony Minessale 2013-05-21 09:29:50 -05:00
  • 36116944a7 FS-5360 Anthony Minessale 2013-05-20 12:22:58 -05:00
  • 3a0ec14130 getting read_impl too soon here Anthony Minessale 2013-05-20 11:22:37 -05:00
  • b399b3363c 1.2.10 Release v1.2.10 Ken Rice 2013-05-20 11:07:35 -05:00
  • 62027c9e7e Add mod_xml_radius to the modules list, though disabled by default. William King 2013-05-18 20:49:51 -07:00
  • 898a487443 Theoretical memory leak where if attr_init failed, then check would have still been malloc'd but not used. William King 2013-05-18 20:42:03 -07:00
  • 4192bf3370 Minor code cleanup. calling va_start without calling va_end doesn't leak does it? Either way, it's fixed now. William King 2013-05-18 20:15:14 -07:00
  • 79e3de3e55 full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors. William King 2013-05-18 19:13:18 -07:00
  • c80d768004 My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer. William King 2013-05-18 17:46:13 -07:00
  • f3393ef362 Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case. William King 2013-05-18 17:34:16 -07:00
  • bd4ea84242 Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak. William King 2013-05-18 17:06:54 -07:00
  • 97286e10cd Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up. William King 2013-05-18 17:00:41 -07:00
  • 14f48a6a7a Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not. William King 2013-05-18 16:34:46 -07:00
  • d61d395e8d If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done. William King 2013-05-18 16:05:40 -07:00
  • dac6ce1b45 FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers. William King 2013-05-18 15:47:01 -07:00
  • 9ce6ce082f When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names. William King 2013-05-18 15:10:44 -07:00
  • 4fc1369a1b Minor typo. User is being passed into this fuction as a long pointer, not a long. William King 2013-05-18 14:29:59 -07:00
  • 49303fdabc read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated. William King 2013-05-18 14:26:40 -07:00
  • 48f423db40 This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated. William King 2013-05-18 13:38:24 -07:00
  • dec5a592ca FS-5434 --resolve Jeff Lenk 2013-05-17 21:38:32 -05:00
  • bf688a87aa fix silence_stream size bug Anthony Minessale 2013-05-17 16:11:04 -05:00
  • fc42d93ddf FS-5441: --resolve William King 2013-05-17 12:39:17 -07:00
  • c8ef74055a FS-5430 --resolve Anthony Minessale 2013-05-15 09:27:18 -05:00
  • 3fe3a0091c FS-5418 --resolve Anthony Minessale 2013-05-15 08:08:41 -05:00
  • 88003520bb FS-5208 --resolve Anthony Minessale 2013-05-15 07:36:56 -05:00
  • 793008a215 FS-5011 try to fill gaps Anthony Minessale 2013-05-14 11:22:48 -05:00
  • d3c5713649 FS-5325 force rebuild Anthony Minessale 2013-05-14 07:44:34 -05:00
  • ec7d8a0118 FS-5416 --resolve just missing the part that registers it Anthony Minessale 2013-05-14 07:38:00 -05:00
  • fcb699c8b7 FS-5407 --resolve Anthony Minessale 2013-05-13 14:21:08 -05:00
  • e8ecb64666 FS-5410 --resolve Anthony Minessale 2013-05-13 13:15:33 -05:00
  • b52994ed5d FS-5325 windows compile (cherry picked from commit d466316ace) Jeff Lenk 2013-05-10 17:31:01 -05:00
  • d125147dd8 add context Raymond Chandler 2013-05-10 16:31:06 -04:00
  • b8b6756a44 FS-5325 Anthony Minessale 2013-05-10 12:55:26 -05:00
  • d6c2b9a2fb FS-5085 the last change helped weed out the real bug which is this commit Anthony Minessale 2013-05-10 10:45:07 -05:00
  • e5754ab3ee FS-5403 --resolve Anthony Minessale 2013-05-10 09:59:02 -05:00
  • e44c278c68 move log message to avoid logging null Anthony Minessale 2013-05-09 14:34:39 -05:00
  • 3fc8f7888a FS-5399 --resolve Anthony Minessale 2013-05-09 14:09:23 -05:00
  • 4f8faf9b78 FS-5325 i'll put the nonblocking in but I still think this is a problem with openssl, a short read is not there every single time you connect, When the lib is in full blocking mode it should be handling the complicated actions internally. As complicated as socket programming is, async ssl is even worse because it requires you to do your own buffering and attemps to read may fail waiting for you to write or vice-versa which should have been handled for us in the lib. non-interruptable syscalls are getting pretty outdated and not enabling it is much less complex than making every socket app on earth be non-blocking Anthony Minessale 2013-05-09 12:56:42 -05:00
  • 3847ae028a FS-5360 --resolve fields are exec-on-max-failures exec-on-max-timeouts pin, needs testing Anthony Minessale 2013-05-09 12:28:43 -05:00
  • a08965601c FS-5390 --resolve Anthony Minessale 2013-05-09 10:29:45 -05:00
  • 646b34a2a2 FS-5398 Anthony Minessale 2013-05-09 10:10:02 -05:00
  • 569da261aa FS-5395: False alarm on a reported valgrind memory leak. The io_private is alloc'd from a memory pool which valgrind sucks at tracking. No need to free this, because it'll get cleared when the memory pool on the rsession is destroyed. William King 2013-05-08 18:45:24 -07:00
  • 924e24a0de FS-5395: --resolve Resolve another mod_rtmp crash where oh specific hangup scenarios there would be a free of variable that wasn't ever malloced William King 2013-05-08 16:31:27 -07:00
  • 2e19cbcc61 FS-5085 I discovered that the bowout is happening from both legs at once, we only need to check this condition on the A side of the loopback bridge Anthony Minessale 2013-05-08 13:17:07 -05:00
  • 7c8c758586 Undo previous change Brian West 2013-05-08 14:40:10 -05:00
  • 3c132c91b3 FS-5288 --resolve Raymond Chandler 2013-05-08 12:53:31 -04:00
  • 5f0d33338e FS-5327 --resolve Raymond Chandler 2013-05-08 13:52:48 -04:00
  • 900b0c1747 FS-5371 --resolve typo Anthony Minessale 2013-05-08 09:18:45 -05:00
  • f4bde33dab Revert "fixed stuck mod_rtmp session when the call is killed from fs side, such as using uuid_kill" William King 2013-05-07 16:04:54 -07:00
  • 2b950b9599 FS-5168 --resolve Anthony Minessale 2013-05-07 14:09:42 -05:00
  • d6cd34143b FS-5325 Anthony Minessale 2013-05-07 11:30:37 -05:00
  • bf3f26b0f8 FS-5383 --resolve Anthony Minessale 2013-05-07 08:31:23 -05:00
  • 7c88f35451 1.2.9 rev bump v1.2.9 Ken Rice 2013-05-06 18:30:47 -05:00
  • c7567d418e fix mod_spandsp on systems with libjbig Ken Rice 2013-05-06 18:23:54 -05:00
  • 99fd7a87ff fix auto in will not use the last slot Michael Jerris 2013-05-06 11:45:30 -04:00
  • 65f0d16dee FS-5371 --resolve Anthony Minessale 2013-05-03 13:38:17 -05:00
  • 749afaa7a3 FS-5365 --resolve Anthony Minessale 2013-05-03 13:13:38 -05:00
  • 3d934ad397 add bgsystem for background system calls Michael Jerris 2013-05-03 16:22:15 -04:00
  • 766db71ecd FS-5085 adding this patch but still wondering what causes this issue Anthony Minessale 2013-05-03 12:30:35 -05:00
  • a062444b4c dress up event fired after parsing a message Anthony Minessale 2013-05-03 11:42:36 -05:00
  • ec0067b04c FS-5240: --resolve Please test William King 2013-05-02 23:57:43 -05:00
  • a30989d769 prevent t38_passthru and fax_detect from both happening at once Anthony Minessale 2013-05-02 22:22:59 -05:00
  • 2e7c219b7e FS-4332: --resolve William King 2013-05-03 00:01:24 -05:00
  • d0e2e9ae9c FS-4875 auto setting ignore_early_media causes unwanted side effects for others, it will have to be supplied by the user Anthony Minessale 2013-05-02 21:21:51 -05:00
  • 95d31525ce FS-5359 --resolve Anthony Minessale 2013-04-30 18:45:24 -05:00
  • 91712b5774 add channel data to this event Brian West 2013-04-30 14:43:47 -05:00
  • 52f867b142 fix stop the correct way Brian West 2013-04-30 13:24:35 -05:00
  • 91f8c53568 add uuid of orig picked channel too Anthony Minessale 2013-04-30 11:57:48 -05:00
  • 99e91acc5f add execute_on_pickup and api_on_pickup Anthony Minessale 2013-04-30 11:41:29 -05:00
  • 85957b9557 fix stopping of streams Brian West 2013-04-30 12:32:45 -05:00
  • a9587acac2 FS-5358 --resolve use allow-transcoding=true param in global settings or fifo_allow_transcoding=true channel var on per caller basis Anthony Minessale 2013-04-30 09:39:35 -05:00
  • 89afd89741 FS-5286 we can try this for added protection Anthony Minessale 2013-04-29 09:19:47 -05:00
  • e23d4d37aa FS-5355 --resolve Anthony Minessale 2013-04-29 10:09:14 -05:00