mirror of
https://github.com/signalwire/freeswitch.git
synced 2026-11-21 00:38:40 +00:00
switch_b64_decode bounded its writes with `ol >= olen - 1`, where `olen` is unsigned. An `olen` of 0 made `olen - 1` wrap to `SIZE_MAX`, so the bound never fired and the loop wrote the entire decoded input plus a trailing NUL past the destination. Reject `olen == 0` and test `ol + 1 >= olen` before each write, so the comparison never subtracts from an unsigned and always leaves room for the terminator. The alphabet lookup table `l64` was a `char` indexed by a `char`, which is unsafe whichever way `char` is signed: - Where `char` is signed, an input byte >= 0x80 became a negative index and read before the table. - Where `char` is unsigned, the `-1` "not in alphabet" sentinel was stored as 255, so the skip test never matched and non-alphabet bytes were folded in as data. Make `l64` a `signed char` and index it with `(unsigned char)`, so the sentinel survives and the index stays in range on every platform. Change the bit accumulator `b` from `int` to `unsigned int` to avoid signed-overflow undefined behavior on long input; decoded output is unchanged. Add unit tests: an encode/decode round-trip across the padding cases, the output-bound edges (`olen` of 0, 1, and a truncating buffer), and a non-alphabet byte (including one >= 0x80) that must be skipped.