ben.carrasco/jambonz-api-server
1
0
Fork 0
mirror of https://github.com/jambonz/jambonz-api-server.git synced 2026-01-25 02:08:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix/526 (#528)

Browse Source 
* calidate webhook urls on update

* don't remove webhooks if not updated

* valid if object exists
This commit is contained in:
Sam Machin
2025-12-19 12:32:20 +00:00
committed by GitHub
parent e02db2e025
commit 4201ebbe9c
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/routes/api/applications.js
View File

@@ -101,6 +101,20 @@ async function validateUpdate(req, sid) {
if (req.body.call_status_hook && typeof req.body.call_hook !== 'object') { if (req.body.call_status_hook && typeof req.body.call_hook !== 'object') {
throw new DbErrorBadRequest('\'call_status_hook\' must be an object when updating an application'); throw new DbErrorBadRequest('\'call_status_hook\' must be an object when updating an application');
} }
let urlError;
if (req.body.call_hook) {
urlError = await isInvalidUrl(req.body.call_hook.url);
if (urlError) {
throw new DbErrorBadRequest(`call_hook ${urlError}`);
}
}
if (req.body.call_status_hook) {
urlError = await isInvalidUrl(req.body.call_status_hook.url);
if (urlError) {
throw new DbErrorBadRequest(`call_status_hook ${urlError}`);
}
}
} }
async function validateDelete(req, sid) { async function validateDelete(req, sid) {
@@ -290,9 +304,6 @@ router.put('/:sid', async(req, res) => {
obj[`${prop}_sid`] = sid; obj[`${prop}_sid`] = sid;
} }
} }
else {
obj[`${prop}_sid`] = null;
}
delete obj[prop]; delete obj[prop];
} }