From 92aef10b92a3640c0bf84d13013047203a528203 Mon Sep 17 00:00:00 2001 From: Dave Horton Date: Fri, 23 Oct 2026 12:55:23 -0400 Subject: [PATCH] chore: pin node 24.22.1 for the eMadhra TLS vulnerability (#570) - Dockerfile, Dockerfile.db-create and test/feature-server-test-scaffold/Dockerfile: node:24-alpine and node:18.6.0-alpine -> node:24.22.1-alpine - CI: setup-node lts/* -> 24.x; checkout, login-action and build-push-action bumped to node24 majors - engines.node -> >= 24.22.1 (package.json and lockfile root) Co-authored-by: Claude Opus 5.5 --- .github/workflows/ci.yml | 6 +++--- .github/workflows/docker-publish-dbcreate.yml | 6 +++--- .github/workflows/docker-publish.yml | 6 +++--- Dockerfile | 2 +- Dockerfile.db-create | 2 +- package-lock.json | 2 +- package.json | 2 +- test/feature-server-test-scaffold/Dockerfile | 2 +- 8 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 43dedda..511a67d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,10 +6,10 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 + - uses: actions/checkout@v7 + - uses: actions/setup-node@v7 with: - node-version: lts/* + node-version: 24.x - run: npm install - run: npm run jslint - run: npm test diff --git a/.github/workflows/docker-publish-dbcreate.yml b/.github/workflows/docker-publish-dbcreate.yml index d363d03..634d49f 100644 --- a/.github/workflows/docker-publish-dbcreate.yml +++ b/.github/workflows/docker-publish-dbcreate.yml @@ -15,7 +15,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: prepare tag id: prepare_tag @@ -38,13 +38,13 @@ jobs: echo "version=$VERSION" >> $GITHUB_OUTPUT - name: Login to Docker Hub - uses: docker/login-action@v3 + uses: docker/login-action@v4 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Build and push Docker image - uses: docker/build-push-action@v6 + uses: docker/build-push-action@v7 with: context: . file: ./Dockerfile.db-create diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml index 6a2d8ca..02dbc88 100644 --- a/.github/workflows/docker-publish.yml +++ b/.github/workflows/docker-publish.yml @@ -15,7 +15,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: prepare tag id: prepare_tag @@ -38,13 +38,13 @@ jobs: echo "version=$VERSION" >> $GITHUB_OUTPUT - name: Login to Docker Hub - uses: docker/login-action@v3 + uses: docker/login-action@v4 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Build and push Docker image - uses: docker/build-push-action@v6 + uses: docker/build-push-action@v7 with: context: . push: true diff --git a/Dockerfile b/Dockerfile index b2d6356..98374c6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM --platform=linux/amd64 node:24-alpine AS base +FROM --platform=linux/amd64 node:24.22.1-alpine AS base RUN apk --update --no-cache add --virtual .builds-deps build-base python3 diff --git a/Dockerfile.db-create b/Dockerfile.db-create index cdb9c4a..cf569d8 100644 --- a/Dockerfile.db-create +++ b/Dockerfile.db-create @@ -1,4 +1,4 @@ -FROM --platform=linux/amd64 node:24-alpine AS base +FROM --platform=linux/amd64 node:24.22.1-alpine AS base RUN apk --update --no-cache add --virtual .builds-deps build-base python3 diff --git a/package-lock.json b/package-lock.json index 572dd83..6a291a4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -63,7 +63,7 @@ "tape": "^5.7.5" }, "engines": { - "node": ">= 20.0.0" + "node": ">= 24.22.1" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index c9c7df3..80b4f95 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "jambonz-api-server", "version": "0.9.15", "engines": { - "node": ">= 20.0.0" + "node": ">= 24.22.1" }, "main": "app.js", "scripts": { diff --git a/test/feature-server-test-scaffold/Dockerfile b/test/feature-server-test-scaffold/Dockerfile index ae3c7c1..7d32707 100644 --- a/test/feature-server-test-scaffold/Dockerfile +++ b/test/feature-server-test-scaffold/Dockerfile @@ -1,4 +1,4 @@ -FROM --platform=linux/amd64 node:18.6.0-alpine as base +FROM --platform=linux/amd64 node:24.22.1-alpine as base RUN apk --update --no-cache add --virtual .builds-deps build-base python3