work on say and gather

lib/tasks/task.js

@@ -1,6 +1,8 @@
 const Emitter = require('events');
 const debug = require('debug')('jambonz:feature-server');
 const assert = require('assert');
+const resourcesMixin = require('../utils/resources');
+const {TaskPreconditions} = require('../utils/constants');
 const specs = new Map();
 const _specData = require('./specs');
 for (const key in _specData) {specs.set(key, _specData[key]);}
@@ -8,10 +10,19 @@ for (const key in _specData) {specs.set(key, _specData[key]);}
 class Task extends Emitter {
   constructor(logger, data) {
     super();
+    this.preconditions = TaskPreconditions.None;
     this.logger = logger;
     this.data = data;
   }
 
+  /**
+   * called to kill (/stop) a running task
+   * what to do is up to each type of task
+   */
+  kill() {
+    // no-op
+  }
+
   static validate(name, data) {
     debug(`validating ${name} with data ${JSON.stringify(data)}`);
     // validate the instruction is supported
@@ -24,6 +35,7 @@ class Task extends Emitter {
       if (dKey in specData.properties) {
         const dVal = data[dKey];
         const dSpec = specData.properties[dKey];
+        debug(`Task:validate validating property ${dKey} with value ${JSON.stringify(dVal)}`);
 
         if (typeof dSpec === 'string' && ['number', 'string', 'object', 'boolean'].includes(dSpec)) {
           // simple types
@@ -31,6 +43,9 @@ class Task extends Emitter {
             throw new Error(`${name}: property ${dKey} has invalid data type`);
           }
         }
+        else if (typeof dSpec === 'string' && dSpec === 'array') {
+          if (!Array.isArray(dVal)) throw new Error(`${name}: property ${dKey} is not an array`);
+        }
         else if (Array.isArray(dSpec) && dSpec[0].startsWith('#')) {
           const name = dSpec[0].slice(1);
           for (const item of dVal) {
@@ -49,8 +64,9 @@ class Task extends Emitter {
         }
         else if (typeof dSpec === 'string' && dSpec.startsWith('#')) {
           // reference to another datatype (i.e. nested type)
-          // TODO: validate recursively
           const name = dSpec.slice(1);
+          //const obj = {};
+          //obj[name] = dVal;
           Task.validate(name, dVal);
         }
         else {
@@ -64,5 +80,7 @@ class Task extends Emitter {
   }
 }
 
+Object.assign(Task.prototype, resourcesMixin);
+
 module.exports = Task;