feat sip indialog actionHook (#477)

* feat sip indialog actionHook

* feat sip indialog actionHook

* feat sip indialog actionHook

* feat sip indialog actionHook

* update verb spec

* fix

* fix

* rename function as required _onRequestWithinDialog

lib/session/call-session.js

@@ -414,6 +414,14 @@ class CallSession extends Emitter {
     this._onHoldMusic = url;
   }
 
+  get sipRequestWithinDialogHook() {
+    return this._sipRequestWithinDialogHook;
+  }
+
+  set sipRequestWithinDialogHook(url) {
+    this._sipRequestWithinDialogHook = url;
+  }
+
   hasGlobalSttPunctuation() {
     return this._globalSttPunctuation !== undefined;
   }
@@ -1646,10 +1654,32 @@ class CallSession extends Emitter {
       }
       this.dlg.on('modify', this._onReinvite.bind(this));
       this.dlg.on('refer', this._onRefer.bind(this));
+      if (this.sipRequestWithinDialogHook) {
+        this.dlg.on('info', this._onRequestWithinDialog.bind(this));
+        this.dlg.on('message', this._onRequestWithinDialog.bind(this));
+      }
       this.logger.debug(`CallSession:propagateAnswer - answered callSid ${this.callSid}`);
     }
   }
 
+  async _onRequestWithinDialog(req, res) {
+    if (!this.sipRequestWithinDialogHook) {
+      return;
+    }
+    const sip_method = req.method;
+    if (sip_method === 'INFO') {
+      res.send(200);
+    } else if (sip_method === 'MESSAGE') {
+      res.send(202);
+    } else {
+      this.logger.info(`CallSession:_onRequestWithinDialog unsported method: ${req.method}`);
+      res.send(501);
+      return;
+    }
+    const params = {sip_method, sip_body: req.body};
+    this.currentTask.performHook(this, this.sipRequestWithinDialogHook, params);
+  }
+
   async _onReinvite(req, res) {
     try {
       if (this.ep) {

lib/tasks/config.js

@@ -216,6 +216,9 @@ class TaskConfig extends Task {
         cs.stopBackgroundListen();
       }
     }
+    if (this.data.sipRequestWithinDialogHook) {
+      cs.sipRequestWithinDialogHook = this.data.sipRequestWithinDialogHook;
+    }
   }
 
   async kill(cs) {

lib/tasks/dial.js

@@ -204,6 +204,7 @@ class TaskDial extends Task {
       await this.performAction(this.results, this.killReason !== KillReason.Replaced);
       this._removeDtmfDetection(cs.dlg);
       this._removeDtmfDetection(this.dlg);
+      this._removeSipIndialogRequestListener(this.dlg);
     } catch (err) {
       this.logger.error({err}, 'TaskDial:exec terminating with error');
       this.kill(cs);
@@ -375,8 +376,14 @@ class TaskDial extends Task {
   }
 
   _onInfo(cs, dlg, req, res) {
+    // SIP Indialog will be handled by another handler
+    if (cs.sipRequestWithinDialogHook) {
+      return;
+    }
     res.send(200);
-    if (req.get('Content-Type') !== 'application/dtmf-relay') return;
+    if (req.get('Content-Type') !== 'application/dtmf-relay') {
+      return;
+    }
 
     const dtmfDetector = dlg === cs.dlg ? this.parentDtmfCollector : this.childDtmfCollector;
     if (!dtmfDetector) return;
@@ -405,6 +412,20 @@ class TaskDial extends Task {
     }
   }
 
+  _initSipIndialogRequestListener(cs, dlg) {
+    dlg.on('info', this._onRequestWithinDialog.bind(this, cs));
+    dlg.on('message', this._onRequestWithinDialog.bind(this, cs));
+  }
+
+  _removeSipIndialogRequestListener(dlg) {
+    dlg && dlg.removeAllListeners('message');
+    dlg && dlg.removeAllListeners('info');
+  }
+
+  async _onRequestWithinDialog(cs, req, res) {
+    cs._onRequestWithinDialog(req, res);
+  }
+
   async _initializeInbound(cs) {
     const {ep} = await cs._evalEndpointPrecondition(this);
     this.epOther = ep;
@@ -712,6 +733,7 @@ class TaskDial extends Task {
 
     if (this.parentDtmfCollector) this._installDtmfDetection(cs, cs.dlg);
     if (this.childDtmfCollector) this._installDtmfDetection(cs, this.dlg);
+    if (cs.sipRequestWithinDialogHook) this._initSipIndialogRequestListener(cs, this.dlg);
 
     if (this.transcribeTask) this.transcribeTask.exec(cs, {ep: this.epOther, ep2:this.ep});
     if (this.listenTask) this.listenTask.exec(cs, {ep: this.epOther});