ben.carrasco/jambonz-feature-server
1
0
Fork 0
mirror of https://github.com/jambonz/jambonz-feature-server.git synced 2025-12-20 16:50:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for issue where we should not delay from gather when JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS is set (#1283)

Browse Source 
* Fix for issue https://github.com/jambonz/jambonz-feature-server/issues/1281

* Commented the reason for the change
This commit is contained in:
rammohan-y
2025-07-17 20:06:22 +05:30
committed by GitHub
parent e0e2ade289
commit 6e7521c91c
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/tasks/gather.js
View File

@@ -390,9 +390,13 @@ class TaskGather extends SttTask {
if (this.digitBuffer.length === 0 && this.needsStt) { if (this.digitBuffer.length === 0 && this.needsStt) {
// DTMF is higher priority than STT. // DTMF is higher priority than STT.
this.removeCustomEventListeners(); this.removeCustomEventListeners();
// Fix for https://github.com/jambonz/jambonz-feature-server/issues/1281
// We should immediately call stop transcription from gather
// so that next gather can start transcription immediately
ep.stopTranscription({ ep.stopTranscription({
vendor: this.vendor, vendor: this.vendor,
bugname: this.bugname, bugname: this.bugname,
gracefulShutdown: false
}) })
.catch((err) => this.logger.error({err}, .catch((err) => this.logger.error({err},
` Received DTMF, Error stopping transcription for vendor ${this.vendor}`)); ` Received DTMF, Error stopping transcription for vendor ${this.vendor}`));
@@ -1236,9 +1240,13 @@ class TaskGather extends SttTask {
async _resolve(reason, evt) { async _resolve(reason, evt) {
this.logger.info({evt}, `TaskGather:resolve with reason ${reason}`); this.logger.info({evt}, `TaskGather:resolve with reason ${reason}`);
if (this.needsStt && this.ep && this.ep.connected) { if (this.needsStt && this.ep && this.ep.connected) {
// Fix for https://github.com/jambonz/jambonz-feature-server/issues/1281
// We should immediately call stop transcription from gather
// so that next gather can start transcription immediately
this.ep.stopTranscription({ this.ep.stopTranscription({
vendor: this.vendor, vendor: this.vendor,
bugname: this.bugname bugname: this.bugname,
gracefulShutdown: false
}) })
.catch((err) => { .catch((err) => {
if (this.resolved) return; if (this.resolved) return;