feat/940 stopped calling updateSpeechCredentialLastUsed (#944)

lib/tasks/gather.js

@@ -140,7 +140,6 @@ class TaskGather extends SttTask {
   async handling(cs, {ep}) {
     this.logger.debug({options: this.data}, 'Gather:exec');
     await super.exec(cs, {ep});
-    const {updateSpeechCredentialLastUsed} = require('../utils/db-utils')(this.logger, cs.srf);
 
     this.fillerNoise = {
       ...(cs.fillerNoise || {}),
@@ -210,7 +209,6 @@ class TaskGather extends SttTask {
             return;
           }
           this._startTranscribing(ep);
-          return updateSpeechCredentialLastUsed(this.sttCredentials.speech_credential_sid);
         } catch (e) {
           await this._startFallback(cs, ep, {error: e});
         }
@@ -290,8 +288,6 @@ class TaskGather extends SttTask {
         await this._setSpeechHandlers(cs, ep);
         if (!this.resolved && !this.killed) {
           this._startTranscribing(ep);
-          updateSpeechCredentialLastUsed(this.sttCredentials.speech_credential_sid)
-            .catch(() => {/*already logged error */});
         }
         else {
           this.logger.info('Gather:exec - task was killed or resolved quickly, not starting transcription');
@@ -969,7 +965,6 @@ class TaskGather extends SttTask {
         bugname: this.bugname
       })
         .catch((err) => this.logger.error({err}, `Error stopping transcription for primary vendor ${this.vendor}`));
-      const {updateSpeechCredentialLastUsed} = require('../utils/db-utils')(this.logger, cs.srf);
       try {
         this.logger.debug('gather:_startFallback');
         this.notifyError({ msg: 'ASR error',
@@ -978,7 +973,6 @@ class TaskGather extends SttTask {
         this._speechHandlersSet = false;
         await this._setSpeechHandlers(cs, ep);
         this._startTranscribing(ep);
-        updateSpeechCredentialLastUsed(this.sttCredentials.speech_credential_sid);
         return true;
       } catch (error) {
         this.logger.info({error}, `There is error while falling back to ${this.fallbackVendor}`);

lib/tasks/transcribe.js

@@ -100,7 +100,6 @@ class TaskTranscribe extends SttTask {
         ...this.data.recognizer.nuanceOptions
       };
     }
-    const {updateSpeechCredentialLastUsed} = require('../utils/db-utils')(this.logger, cs.srf);
 
     if (cs.hasGlobalSttHints) {
       const {hints, hintsBoost} = cs.globalSttHints;
@@ -117,9 +116,6 @@ class TaskTranscribe extends SttTask {
       if (this.transcribing2) {
         await this._startTranscribing(cs, ep2, 2);
       }
-
-      updateSpeechCredentialLastUsed(this.sttCredentials.speech_credential_sid)
-        .catch(() => {/*already logged error */});
     } catch (err) {
       if (!(await this._startFallback(cs, ep, {error: err}))) {
         this.logger.info(err, 'TaskTranscribe:exec - error');
@@ -601,7 +597,6 @@ class TaskTranscribe extends SttTask {
         bugname: this.bugname
       })
         .catch((err) => this.logger.error({err}, `Error stopping transcription for primary vendor ${this.vendor}`));
-      const {updateSpeechCredentialLastUsed} = require('../utils/db-utils')(this.logger, cs.srf);
       try {
         this.notifyError({ msg: 'ASR error',
           details:`STT Vendor ${this.vendor} error: ${evt.error || evt.reason}`, failover: 'in progress'});
@@ -612,7 +607,6 @@ class TaskTranscribe extends SttTask {
         }
         this[`_speechHandlersSet_${channel}`] = false;
         this._startTranscribing(cs, _ep, channel);
-        updateSpeechCredentialLastUsed(this.sttCredentials.speech_credential_sid);
         return true;
       } catch (error) {
         this.notifyError({ msg: 'ASR error',

lib/tasks/tts-task.js

@@ -46,7 +46,6 @@ class TtsTask extends Task {
 
   async _synthesizeWithSpecificVendor(cs, ep, {vendor, language, voice, label, preCache = false}) {
     const {srf, accountSid:account_sid} = cs;
-    const {updateSpeechCredentialLastUsed} = require('../utils/db-utils')(this.logger, srf);
     const {writeAlerts, AlertType, stats} = srf.locals;
     const {synthAudio} = srf.locals.dbHelpers;
     const engine = this.synthesizer.engine || cs.synthesizer?.engine || 'neural';
@@ -141,8 +140,6 @@ class TtsTask extends Task {
         }).catch((err) => this.logger.info({err}, 'Error generating alert for no tts'));
         throw new SpeechCredentialError('no provisioned speech credentials for TTS');
       }
-      // synthesize all of the text elements
-      let lastUpdated = false;
 
       /* produce an audio segment from the provided text */
       const generateAudio = async(text) => {
@@ -182,10 +179,6 @@ class TtsTask extends Task {
               this.otelSpan.end();
               this.otelSpan = null;
             }
-            if (!servedFromCache && !lastUpdated) {
-              lastUpdated = true;
-              updateSpeechCredentialLastUsed(credentials.speech_credential_sid).catch(() => {/* logged error */});
-            }
             if (!servedFromCache && rtt && !preCache  && !this._disableTracing) {
               this.notifyStatus({
                 event: 'synthesized-audio',