ben.carrasco/jambonz-feature-server
1
0
Fork 0
mirror of https://github.com/jambonz/jambonz-feature-server.git synced 2025-12-20 08:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

handle missing callerId property for anonymous calls

Browse Source
This commit is contained in:
Dave Horton
2023-05-25 13:28:42 -04:00
parent 863c4dfa34
commit 90468ffe48
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/http-routes/api/create-call.js
View File

@@ -92,7 +92,8 @@ router.post('/', async(req, res) => {
* */ * */
if (target.type === 'phone' && !target.trunk) { if (target.type === 'phone' && !target.trunk) {
const {lookupCarrierByPhoneNumber} = dbUtils(this.logger, srf); const {lookupCarrierByPhoneNumber} = dbUtils(this.logger, srf);
const callingNumber = restDial.from.startsWith('+') ? restDial.from.substring(1) : restDial.from; const str = restDial.from || '';
const callingNumber = str.startsWith('+') ? str.substring(1) : str;
const voip_carrier_sid = await lookupCarrierByPhoneNumber(req.body.account_sid, callingNumber); const voip_carrier_sid = await lookupCarrierByPhoneNumber(req.body.account_sid, callingNumber);
logger.info( logger.info(
`createCall: selected ${voip_carrier_sid} for requested phone number: ${callingNumber || 'unspecified'})`); `createCall: selected ${voip_carrier_sid} for requested phone number: ${callingNumber || 'unspecified'})`);

2
lib/tasks/dial.js
View File

@@ -470,7 +470,7 @@ class TaskDial extends Task {
* check if number matches any existing numbers * check if number matches any existing numbers
* */ * */
if (t.type === 'phone' && !t.trunk) { if (t.type === 'phone' && !t.trunk) {
const str = this.callerId || req.callingNumber; const str = this.callerId || req.callingNumber || '';
const callingNumber = str.startsWith('+') ? str.substring(1) : str; const callingNumber = str.startsWith('+') ? str.substring(1) : str;
const voip_carrier_sid = await lookupCarrierByPhoneNumber(req.body.account_sid, callingNumber); const voip_carrier_sid = await lookupCarrierByPhoneNumber(req.body.account_sid, callingNumber);
this.logger.info( this.logger.info(