ben.carrasco/jambonz-feature-server
1
0
Fork 0
mirror of https://github.com/jambonz/jambonz-feature-server.git synced 2025-12-20 16:50:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix assert, and force methods to upper case (#1304)

Browse Source 
* fix assert, and force methods to upper case

* add alert for updateCall errors

* lint

* handle missing method
This commit is contained in:
Sam Machin
2025-07-30 13:32:15 +01:00
committed by GitHub
parent 94d43d4b70
commit b478e0ecd2
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/session/call-session.js
View File

@@ -1963,6 +1963,17 @@ Duration=${duration} `
} }
} catch (err) { } catch (err) {
this.logger.info({err, opts, callSid}, 'CallSession:updateCall - error updating call'); this.logger.info({err, opts, callSid}, 'CallSession:updateCall - error updating call');
const {writeAlerts} = this.srf.locals;
try {
writeAlerts({
alert_type: 'error-updating-call',
account_sid: this.accountSid,
message: err.message,
target_sid: callSid
});
} catch (err) {
this.logger.error({err}, 'Error writing error-updating-call alert');
}
} }
} }

6
lib/utils/http-requestor.js
View File

@@ -41,7 +41,7 @@ class HttpRequestor extends BaseRequestor {
constructor(logger, account_sid, hook, secret) { constructor(logger, account_sid, hook, secret) {
super(logger, account_sid, hook, secret); super(logger, account_sid, hook, secret);
this.method = hook.method || 'POST'; this.method = hook.method?.toUpperCase() || 'POST';
this.authHeader = basicAuth(hook.username, hook.password); this.authHeader = basicAuth(hook.username, hook.password);
this.backoffMs = 500; this.backoffMs = 500;
@@ -111,7 +111,7 @@ class HttpRequestor extends BaseRequestor {
const payload = params ? snakeCaseKeys(params, ['customerData', 'sip', 'env_vars', 'args']) : null; const payload = params ? snakeCaseKeys(params, ['customerData', 'sip', 'env_vars', 'args']) : null;
const url = hook.url || hook; const url = hook.url || hook;
const method = hook.method || 'POST'; const method = hook.method?.toUpperCase() || 'POST';
let buf = ''; let buf = '';
httpHeaders = { httpHeaders = {
...httpHeaders, ...httpHeaders,
@@ -119,7 +119,7 @@ class HttpRequestor extends BaseRequestor {
}; };
assert.ok(url, 'HttpRequestor:request url was not provided'); assert.ok(url, 'HttpRequestor:request url was not provided');
assert.ok, (['GET', 'POST'].includes(method), `HttpRequestor:request method must be 'GET' or 'POST' not ${method}`); assert.ok(['GET', 'POST'].includes(method), `HttpRequestor:request method must be 'GET' or 'POST' not ${method}`);
const startAt = process.hrtime(); const startAt = process.hrtime();
/* if we have an absolute url, and it is ws then do a websocket connection */ /* if we have an absolute url, and it is ws then do a websocket connection */