diff --git a/api/src/backend/api/tests/test_serializers.py b/api/src/backend/api/tests/test_serializers.py index 60b2a959ab..33858f3d7a 100644 --- a/api/src/backend/api/tests/test_serializers.py +++ b/api/src/backend/api/tests/test_serializers.py @@ -288,7 +288,7 @@ class TestAzureProviderSecret: assert not serializer.is_valid() assert "certificate_content" in serializer.errors - def test_rejects_invalid_tenant_and_client_ids(self): + def test_accepts_non_uuid_tenant_and_client_ids_for_backward_compatibility(self): serializer = AzureProviderSecret( data={ "tenant_id": "not-a-uuid", @@ -297,9 +297,7 @@ class TestAzureProviderSecret: } ) - assert not serializer.is_valid() - assert "tenant_id" in serializer.errors - assert "client_id" in serializer.errors + assert serializer.is_valid(), serializer.errors def test_rejects_key_only_certificate_content(self): import base64 diff --git a/api/src/backend/api/v1/serializers.py b/api/src/backend/api/v1/serializers.py index 549cbf204b..b56aa09b7c 100644 --- a/api/src/backend/api/v1/serializers.py +++ b/api/src/backend/api/v1/serializers.py @@ -2,7 +2,6 @@ import base64 import json import logging from datetime import UTC, datetime, timedelta -from uuid import UUID import yaml from api.celery_utils import decode_celery_field @@ -1795,24 +1794,6 @@ class AzureProviderSecret(serializers.Serializer): tenant_id = serializers.CharField() certificate_content = serializers.CharField(required=False) - def validate_client_id(self, client_id): - try: - UUID(client_id) - except (TypeError, ValueError) as error: - raise serializers.ValidationError( - "Client ID must be a valid UUID." - ) from error - return client_id - - def validate_tenant_id(self, tenant_id): - try: - UUID(tenant_id) - except (TypeError, ValueError) as error: - raise serializers.ValidationError( - "Tenant ID must be a valid UUID." - ) from error - return tenant_id - def validate(self, attrs): if attrs.get("client_secret") and attrs.get("certificate_content"): raise serializers.ValidationError(