ben.carrasco/prowler
1
0 Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-10-24 12:24:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(arn): fine tune arn and resources id for unknown values (#5841)

Browse Source
This commit is contained in:
Pedro Martín authored and GitHub committed 2024-11-20 12:56:51 +01:00
1 parent b06e549d81
commit 096749a455
13 files changed
+95 -48
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/providers/aws/services/securityhub/securityhub_enabled/securityhub_enabled_test.py
+6 -6
View File
@@ -11,12 +11,12 @@ class Test_securityhub_enabled:
securityhub_client = mock.MagicMock
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.get_unknown_arn = (
lambda x: f"arn:aws:securityhub:{x}:0123456789012:unknown"
lambda x: f"arn:aws:securityhub:{x}:0123456789012:hub/unknown"
)
securityhub_client.securityhubs = [
SecurityHubHub(
arn=f"arn:aws:securityhub:{AWS_REGION_EU_WEST_1}:0123456789012:unknown",
id="Security Hub",
arn=f"arn:aws:securityhub:{AWS_REGION_EU_WEST_1}:0123456789012:hub/unknown",
id="hub/unknown",
status="NOT_AVAILABLE",
standards="",
integrations="",
@@ -29,7 +29,7 @@ class Test_securityhub_enabled:
new=securityhub_client,
), mock.patch(
"prowler.providers.aws.services.securityhub.securityhub_service.SecurityHub.get_unknown_arn",
return_value="arn:aws:securityhub:eu-west-1:0123456789012:unknown",
return_value="arn:aws:securityhub:eu-west-1:0123456789012:hub/unknown",
):
# Test Check
from prowler.providers.aws.services.securityhub.securityhub_enabled.securityhub_enabled import (
@@ -41,10 +41,10 @@ class Test_securityhub_enabled:
assert result[0].status == "FAIL"
assert result[0].status_extended == "Security Hub is not enabled."
assert result[0].resource_id == "Security Hub"
assert result[0].resource_id == "hub/unknown"
assert (
result[0].resource_arn
== "arn:aws:securityhub:eu-west-1:0123456789012:unknown"
== "arn:aws:securityhub:eu-west-1:0123456789012:hub/unknown"
)
assert result[0].region == AWS_REGION_EU_WEST_1
assert result[0].resource_tags == [{"test_key": "test_value"}]