feat(defender): add new check defender_antispam_connection_filter_policy_safe_list_off (#7494)

Co-authored-by: HugoPBrito <hugopbrit@gmail.com>
Co-authored-by: MrCloudSec <hello@mistercloudsec.com>
This commit is contained in:
authored and GitHub committed 2025-04-22 12:52:34 -04:00
1 parent d816d73174
commit 098382117e
9 files changed
+210 -2

No files matched your search

@@ -32,6 +32,7 @@ class Test_defender_antispam_connection_filter_policy_empty_ip_allowlist:
defender_client.connection_filter_policy = ConnectionFilterPolicy(
ip_allow_list=[],
identity="Default",
enable_safe_list=False,
)
check = defender_antispam_connection_filter_policy_empty_ip_allowlist()
@@ -78,6 +79,7 @@ class Test_defender_antispam_connection_filter_policy_empty_ip_allowlist:
defender_client.connection_filter_policy = ConnectionFilterPolicy(
ip_allow_list=["192.168.0.1", "10.0.0.5"],
identity="Default",
enable_safe_list=False,
)
check = defender_antispam_connection_filter_policy_empty_ip_allowlist()
@@ -0,0 +1,128 @@
from unittest import mock
from tests.providers.m365.m365_fixtures import DOMAIN, set_mocked_m365_provider
class Test_defender_antispam_connection_filter_policy_safe_list_off:
def test_safe_list_off(self):
defender_client = mock.MagicMock()
defender_client.audited_tenant = "audited_tenant"
defender_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_exchange_online"
),
mock.patch(
"prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off.defender_client",
new=defender_client,
),
):
from prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off import (
defender_antispam_connection_filter_policy_safe_list_off,
)
from prowler.providers.m365.services.defender.defender_service import (
ConnectionFilterPolicy,
)
defender_client.connection_filter_policy = ConnectionFilterPolicy(
ip_allow_list=[],
identity="Default",
enable_safe_list=False,
)
check = defender_antispam_connection_filter_policy_safe_list_off()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
assert (
result[0].status_extended
== "Safe List is disabled in the Antispam Connection Filter Policy Default."
)
assert result[0].resource == defender_client.connection_filter_policy.dict()
assert (
result[0].resource_name == "Defender Antispam Connection Filter Policy"
)
assert result[0].resource_id == "Default"
assert result[0].location == "global"
def test_safe_list_on(self):
defender_client = mock.MagicMock()
defender_client.audited_tenant = "audited_tenant"
defender_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_exchange_online"
),
mock.patch(
"prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off.defender_client",
new=defender_client,
),
):
from prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off import (
defender_antispam_connection_filter_policy_safe_list_off,
)
from prowler.providers.m365.services.defender.defender_service import (
ConnectionFilterPolicy,
)
defender_client.connection_filter_policy = ConnectionFilterPolicy(
ip_allow_list=[],
identity="Default",
enable_safe_list=True,
)
check = defender_antispam_connection_filter_policy_safe_list_off()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== "Safe List is not disabled in the Antispam Connection Filter Policy Default."
)
assert result[0].resource == defender_client.connection_filter_policy.dict()
assert (
result[0].resource_name == "Defender Antispam Connection Filter Policy"
)
assert result[0].resource_id == "Default"
assert result[0].location == "global"
def test_no_connection_filter_policy(self):
defender_client = mock.MagicMock()
defender_client.audited_tenant = "audited_tenant"
defender_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_exchange_online"
),
mock.patch(
"prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off.defender_client",
new=defender_client,
),
):
from prowler.providers.m365.services.defender.defender_antispam_connection_filter_policy_safe_list_off.defender_antispam_connection_filter_policy_safe_list_off import (
defender_antispam_connection_filter_policy_safe_list_off,
)
defender_client.connection_filter_policy = None
check = defender_antispam_connection_filter_policy_safe_list_off()
result = check.execute()
assert len(result) == 0
@@ -74,6 +74,7 @@ def mock_defender_get_connection_filter_policy(_):
return ConnectionFilterPolicy(
ip_allow_list=[],
identity="Default",
enable_safe_list=False,
)
@@ -244,6 +245,7 @@ class Test_Defender_Service:
connection_filter_policy = defender_client.connection_filter_policy
assert connection_filter_policy.ip_allow_list == []
assert connection_filter_policy.identity == "Default"
assert connection_filter_policy.enable_safe_list is False
defender_client.powershell.close()
@patch(