From 2a8b04cced18038d0c08aafa6675169fbc65d922 Mon Sep 17 00:00:00 2001 From: Prowler Bot Date: Thu, 27 Mar 2025 09:13:16 +0100 Subject: [PATCH] fix(fms): resource metadata could not be converted to dict (#7388) Co-authored-by: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com> --- .../fms/fms_policy_compliant/fms_policy_compliant.py | 4 +--- .../fms/fms_policy_compliant/fms_policy_compliant_test.py | 5 +++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/prowler/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant.py b/prowler/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant.py index a36cd9f8e0..ebe1660aff 100644 --- a/prowler/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant.py +++ b/prowler/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant.py @@ -6,9 +6,7 @@ class fms_policy_compliant(Check): def execute(self): findings = [] if fms_client.fms_admin_account: - report = Check_Report_AWS( - metadata=self.metadata(), resource=fms_client.fms_policies - ) + report = Check_Report_AWS(metadata=self.metadata(), resource={}) report.region = fms_client.region report.resource_arn = fms_client.policy_arn_template report.resource_id = fms_client.audited_account diff --git a/tests/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant_test.py b/tests/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant_test.py index 0c6fa8606a..4810d6c1e6 100644 --- a/tests/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant_test.py +++ b/tests/providers/aws/services/fms/fms_policy_compliant/fms_policy_compliant_test.py @@ -97,6 +97,7 @@ class Test_fms_policy_compliant: == f"arn:aws:fms:{AWS_REGION_US_EAST_1}:{AWS_ACCOUNT_NUMBER}:policy" ) assert result[0].region == AWS_REGION_US_EAST_1 + assert result[0].resource == fms_client.fms_policies[0] def test_fms_admin_with_compliant_policies(self): fms_client = mock.MagicMock @@ -150,6 +151,7 @@ class Test_fms_policy_compliant: == f"arn:aws:fms:{AWS_REGION_US_EAST_1}:{AWS_ACCOUNT_NUMBER}:policy" ) assert result[0].region == AWS_REGION_US_EAST_1 + assert result[0].resource == {} def test_fms_admin_with_non_and_compliant_policies(self): fms_client = mock.MagicMock @@ -209,6 +211,7 @@ class Test_fms_policy_compliant: == f"arn:aws:fms:{AWS_REGION_US_EAST_1}:{AWS_ACCOUNT_NUMBER}:policy" ) assert result[0].region == AWS_REGION_US_EAST_1 + assert result[0].resource == fms_client.fms_policies[0] def test_fms_admin_without_policies(self): fms_client = mock.MagicMock @@ -246,6 +249,7 @@ class Test_fms_policy_compliant: == f"arn:aws:fms:{AWS_REGION_US_EAST_1}:{AWS_ACCOUNT_NUMBER}:policy" ) assert result[0].region == AWS_REGION_US_EAST_1 + assert result[0].resource == {} def test_fms_admin_with_policy_with_null_status(self): fms_client = mock.MagicMock @@ -297,3 +301,4 @@ class Test_fms_policy_compliant: assert result[0].resource_id == "12345678901" assert result[0].resource_arn == "arn:aws:fms:us-east-1:12345678901" assert result[0].region == AWS_REGION_US_EAST_1 + assert result[0].resource == fms_client.fms_policies[0]