diff --git a/prowler/changelog.d/cloudflare-challenge-ttl-none.fixed.md b/prowler/changelog.d/cloudflare-challenge-ttl-none.fixed.md index 26c22b4b3b..b700bb64e4 100644 --- a/prowler/changelog.d/cloudflare-challenge-ttl-none.fixed.md +++ b/prowler/changelog.d/cloudflare-challenge-ttl-none.fixed.md @@ -1 +1 @@ -`zone_challenge_passage_configured` no longer fails when a Cloudflare zone has no challenge passage TTL configured +Zones without a challenge passage TTL are reported as non-compliant by `zone_challenge_passage_configured` diff --git a/tests/providers/cloudflare/cloudflare_provider_test.py b/tests/providers/cloudflare/cloudflare_provider_test.py index 5db4c79537..7b6b9c759e 100644 --- a/tests/providers/cloudflare/cloudflare_provider_test.py +++ b/tests/providers/cloudflare/cloudflare_provider_test.py @@ -318,6 +318,7 @@ class TestCloudflareValidateCredentials: response=MagicMock(status_code=403), body=None, ) + mock_client.accounts.list.return_value = iter([]) session = CloudflareSession( client=mock_client, @@ -328,6 +329,7 @@ class TestCloudflareValidateCredentials: with pytest.raises(CloudflareNoAccountsError): CloudflareProvider.validate_credentials(session) + mock_client.user.get.assert_called_once() mock_client.accounts.list.assert_called_once() def test_validate_credentials_invalid_api_token(self): @@ -497,6 +499,7 @@ class TestCloudflareTestConnection: response=MagicMock(status_code=403), body=None, ) + mock_client.accounts.list.return_value = iter([]) with patch( "prowler.providers.cloudflare.cloudflare_provider.CloudflareProvider.setup_session", @@ -514,6 +517,7 @@ class TestCloudflareTestConnection: assert connection.is_connected is False assert isinstance(connection.error, CloudflareNoAccountsError) assert "No Cloudflare accounts found" in str(connection.error) + mock_client.user.get.assert_called_once() mock_client.accounts.list.assert_called_once() def test_test_connection_invalid_api_key(self):