From 3654e5a8106c97490c02319d33cdc6c3e485d377 Mon Sep 17 00:00:00 2001 From: Alejandro Bailo <59607668+alejandrobailo@users.noreply.github.com> Date: Mon, 19 Oct 2026 16:32:16 +0200 Subject: [PATCH] fix(ui): drop the New badges from the Alerts and Scans sidebar items (#13092) Co-authored-by: Claude Fable 5.1 --- .../layout/app-sidebar/navigation-config.test.ts | 16 +++++++++------- .../layout/app-sidebar/navigation-config.ts | 1 - 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/ui/components/layout/app-sidebar/navigation-config.test.ts b/ui/components/layout/app-sidebar/navigation-config.test.ts index 57793169f3..627929d8cb 100644 --- a/ui/components/layout/app-sidebar/navigation-config.test.ts +++ b/ui/components/layout/app-sidebar/navigation-config.test.ts @@ -139,7 +139,7 @@ describe("getNavigationConfig", () => { expect(labels).not.toContain("Issues"); }); - it("uses Cloud destinations and current New badges", () => { + it("uses Cloud destinations and keeps Configuration children unbadged", () => { // Given vi.stubEnv("UI_CLOUD_ENABLED", "true"); @@ -166,12 +166,14 @@ describe("getNavigationConfig", () => { expect.objectContaining({ label: "CLI Import" }), ]), ); - expect( - configuration.children.find((item) => item.label === "Alerts"), - ).toEqual(expect.objectContaining({ highlight: true })); - expect( - configuration.children.find((item) => item.label === "Scans"), - ).toEqual(expect.objectContaining({ active: true, highlight: true })); + const alerts = configuration.children.find( + (item) => item.label === "Alerts", + ); + const scans = configuration.children.find((item) => item.label === "Scans"); + expect(alerts).toMatchObject({ href: "/alerts" }); + expect(alerts).not.toHaveProperty("highlight"); + expect(scans).toMatchObject({ href: "/scans/config", active: true }); + expect(scans).not.toHaveProperty("highlight"); expect(items.find((item) => item.label === "Attack Paths")).not.toEqual( expect.objectContaining({ highlight: true }), ); diff --git a/ui/components/layout/app-sidebar/navigation-config.ts b/ui/components/layout/app-sidebar/navigation-config.ts index 9c7386c51d..fe4a114f60 100644 --- a/ui/components/layout/app-sidebar/navigation-config.ts +++ b/ui/components/layout/app-sidebar/navigation-config.ts @@ -68,7 +68,6 @@ function getCloudFeature({ href, label, active, - highlight: true, }; }