From 38c9187a5e0324b03629fae3cee4ef8f4426f281 Mon Sep 17 00:00:00 2001 From: sansns-aws <107269923+sansns@users.noreply.github.com> Date: Tue, 28 May 2024 11:43:53 -0400 Subject: [PATCH] fix(rds): ParameterValue MySQL and MariaDB RDS Instances (#4116) --- .../rds_instance_transport_encrypted.py | 2 +- .../rds_instance_transport_encrypted_test.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py b/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py index b51748213d..adc975fe61 100644 --- a/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py +++ b/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py @@ -50,7 +50,7 @@ class rds_instance_transport_encrypted(Check): for parameter in db_instance.parameters: if ( parameter["ParameterName"] == "require_secure_transport" - and parameter.get("ParameterValue", "OFF") == "ON" + and parameter.get("ParameterValue", "0") == "1" ): report.status = "PASS" report.status_extended = f"RDS Instance {db_instance.id} connections use SSL encryption." diff --git a/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py b/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py index fc73bf1a72..fd07dffae6 100644 --- a/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py +++ b/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py @@ -250,7 +250,7 @@ class Test_rds_instance_transport_encrypted: Parameters=[ { "ParameterName": "require_secure_transport", - "ParameterValue": "OFF", + "ParameterValue": "0", "ApplyMethod": "immediate", }, ], @@ -312,7 +312,7 @@ class Test_rds_instance_transport_encrypted: Parameters=[ { "ParameterName": "require_secure_transport", - "ParameterValue": "ON", + "ParameterValue": "1", "ApplyMethod": "immediate", }, ],