From 481a43f3f6d14963289d4087e9815e8f855ff494 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Jes=C3=BAs=20Pe=C3=B1a=20Rodr=C3=ADguez?= Date: Wed, 6 Aug 2025 09:16:26 +0200 Subject: [PATCH] chore(integrations): remove unnecessary error alerts (#8453) --- api/src/backend/tasks/jobs/integrations.py | 8 +++++--- api/src/backend/tasks/tests/test_integrations.py | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/api/src/backend/tasks/jobs/integrations.py b/api/src/backend/tasks/jobs/integrations.py index 1955f28bb1..52bd744d76 100644 --- a/api/src/backend/tasks/jobs/integrations.py +++ b/api/src/backend/tasks/jobs/integrations.py @@ -84,9 +84,11 @@ def upload_s3_integration( try: connected, s3 = get_s3_client_from_integration(integration) except Exception as e: - logger.error( + logger.info( f"S3 connection failed for integration {integration.id}: {e}" ) + integration.connected = False + integration.save() continue if connected: @@ -138,7 +140,7 @@ def upload_s3_integration( integration.connected = False integration.save() logger.error( - f"S3 upload failed for integration {integration.id}: {s3.error}" + f"S3 upload failed, connection failed for integration {integration.id}: {s3.error}" ) result = integration_executions == len(integrations) @@ -147,7 +149,7 @@ def upload_s3_integration( f"All the S3 integrations completed successfully for provider {provider_id}" ) else: - logger.error(f"Some S3 integrations failed for provider {provider_id}") + logger.info(f"Some S3 integrations failed for provider {provider_id}") return result except Exception as e: logger.error(f"S3 integrations failed for provider {provider_id}: {str(e)}") diff --git a/api/src/backend/tasks/tests/test_integrations.py b/api/src/backend/tasks/tests/test_integrations.py index 8f047b304b..538f892718 100644 --- a/api/src/backend/tasks/tests/test_integrations.py +++ b/api/src/backend/tasks/tests/test_integrations.py @@ -161,7 +161,7 @@ class TestS3IntegrationUploads: integration.save.assert_called_once() assert integration.connected is False mock_logger.error.assert_any_call( - "S3 upload failed for integration i-1: Connection failed" + "S3 upload failed, connection failed for integration i-1: Connection failed" ) @patch("tasks.jobs.integrations.rls_transaction") @@ -204,7 +204,7 @@ class TestS3IntegrationUploads: result = upload_s3_integration(tenant_id, provider_id, output_directory) assert result is False - mock_logger.error.assert_any_call( + mock_logger.info.assert_any_call( "S3 connection failed for integration i-1: failed" )