From 4ab392a4c1aac699f366e4e9e84f674507f402d9 Mon Sep 17 00:00:00 2001 From: HugoPBrito Date: Thu, 13 Mar 2025 20:08:36 +0100 Subject: [PATCH] refactor: rename entra_identity_protection_sign_in_risk_enabled --- .../__init__.py | 0 ...ection_sign_in_risk_enabled.metadata.json} | 2 +- ...entity_protection_sign_in_risk_enabled.py} | 2 +- ...y_protection_sign_in_risk_enabled_test.py} | 42 +++++++++---------- 4 files changed, 23 insertions(+), 23 deletions(-) rename prowler/providers/microsoft365/services/entra/{entra_identity_protection_sign_in_risk_enabled => entra_ca_policy_identity_protection_sign_in_risk_enabled}/__init__.py (100%) rename prowler/providers/microsoft365/services/entra/{entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.metadata.json => entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.metadata.json} (96%) rename prowler/providers/microsoft365/services/entra/{entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.py => entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.py} (97%) rename tests/providers/microsoft365/services/entra/{entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled_test.py => entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled_test.py} (87%) diff --git a/prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/__init__.py b/prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/__init__.py similarity index 100% rename from prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/__init__.py rename to prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/__init__.py diff --git a/prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.metadata.json b/prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.metadata.json similarity index 96% rename from prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.metadata.json rename to prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.metadata.json index 039071202c..e5fbb950c0 100644 --- a/prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.metadata.json +++ b/prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.metadata.json @@ -1,6 +1,6 @@ { "Provider": "microsoft365", - "CheckID": "entra_identity_protection_sign_in_risk_enabled", + "CheckID": "entra_ca_policy_identity_protection_sign_in_risk_enabled", "CheckTitle": "Ensure that Identity Protection sign-in risk policies are enabled", "CheckType": [], "ServiceName": "entra", diff --git a/prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.py b/prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.py similarity index 97% rename from prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.py rename to prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.py index 29b33cdc3e..e13ca869c6 100644 --- a/prowler/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled.py +++ b/prowler/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled.py @@ -8,7 +8,7 @@ from prowler.providers.microsoft365.services.entra.entra_service import ( ) -class entra_identity_protection_sign_in_risk_enabled(Check): +class entra_ca_policy_identity_protection_sign_in_risk_enabled(Check): """Check if at least one Conditional Access policy is a Identity Protection sign-in risk policy. This check ensures that at least one Conditional Access policy is a Identity Protection sign-in risk policy. diff --git a/tests/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled_test.py b/tests/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled_test.py similarity index 87% rename from tests/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled_test.py rename to tests/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled_test.py index fd6ff82a91..662323bbc6 100644 --- a/tests/providers/microsoft365/services/entra/entra_identity_protection_sign_in_risk_enabled/entra_identity_protection_sign_in_risk_enabled_test.py +++ b/tests/providers/microsoft365/services/entra/entra_ca_policy_identity_protection_sign_in_risk_enabled/entra_ca_policy_identity_protection_sign_in_risk_enabled_test.py @@ -21,7 +21,7 @@ from tests.providers.microsoft365.microsoft365_fixtures import ( ) -class Test_entra_identity_protection_sign_in_risk_enabled: +class Test_entra_ca_policy_identity_protection_sign_in_risk_enabled: def test_entra_no_conditional_access_policies(self): entra_client = mock.MagicMock entra_client.audited_tenant = "audited_tenant" @@ -32,17 +32,17 @@ class Test_entra_identity_protection_sign_in_risk_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled import ( - entra_identity_protection_sign_in_risk_enabled, + from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import ( + entra_ca_policy_identity_protection_sign_in_risk_enabled, ) entra_client.conditional_access_policies = {} - check = entra_identity_protection_sign_in_risk_enabled() + check = entra_ca_policy_identity_protection_sign_in_risk_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "FAIL" @@ -67,12 +67,12 @@ class Test_entra_identity_protection_sign_in_risk_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled import ( - entra_identity_protection_sign_in_risk_enabled, + from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import ( + entra_ca_policy_identity_protection_sign_in_risk_enabled, ) from prowler.providers.microsoft365.services.entra.entra_service import ( ConditionalAccessPolicy, @@ -115,7 +115,7 @@ class Test_entra_identity_protection_sign_in_risk_enabled: ) } - check = entra_identity_protection_sign_in_risk_enabled() + check = entra_ca_policy_identity_protection_sign_in_risk_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "FAIL" @@ -141,12 +141,12 @@ class Test_entra_identity_protection_sign_in_risk_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled import ( - entra_identity_protection_sign_in_risk_enabled, + from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import ( + entra_ca_policy_identity_protection_sign_in_risk_enabled, ) from prowler.providers.microsoft365.services.entra.entra_service import ( ConditionalAccessPolicy, @@ -194,7 +194,7 @@ class Test_entra_identity_protection_sign_in_risk_enabled: ) } - check = entra_identity_protection_sign_in_risk_enabled() + check = entra_ca_policy_identity_protection_sign_in_risk_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "FAIL" @@ -223,12 +223,12 @@ class Test_entra_identity_protection_sign_in_risk_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled import ( - entra_identity_protection_sign_in_risk_enabled, + from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import ( + entra_ca_policy_identity_protection_sign_in_risk_enabled, ) from prowler.providers.microsoft365.services.entra.entra_service import ( ConditionalAccessPolicy, @@ -276,7 +276,7 @@ class Test_entra_identity_protection_sign_in_risk_enabled: ) } - check = entra_identity_protection_sign_in_risk_enabled() + check = entra_ca_policy_identity_protection_sign_in_risk_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "FAIL" @@ -305,12 +305,12 @@ class Test_entra_identity_protection_sign_in_risk_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_identity_protection_sign_in_risk_enabled.entra_identity_protection_sign_in_risk_enabled import ( - entra_identity_protection_sign_in_risk_enabled, + from prowler.providers.microsoft365.services.entra.entra_ca_policy_identity_protection_sign_in_risk_enabled.entra_ca_policy_identity_protection_sign_in_risk_enabled import ( + entra_ca_policy_identity_protection_sign_in_risk_enabled, ) from prowler.providers.microsoft365.services.entra.entra_service import ( ConditionalAccessPolicy, @@ -358,7 +358,7 @@ class Test_entra_identity_protection_sign_in_risk_enabled: ) } - check = entra_identity_protection_sign_in_risk_enabled() + check = entra_ca_policy_identity_protection_sign_in_risk_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "PASS"