refactor(azure): log certificate parsing errors and tighten cert tests

Address CodeRabbit review:
- Log caught exceptions in the certificate content and path validation
  handlers so failures are diagnosable from the log file, matching the
  established caught-exception logging idiom.
- Assert the full credentials dict in the certificate acceptance tests
  so a stray truthy client_secret or certificate_content that would
  route setup_session to the wrong branch is caught.
This commit is contained in:
Lydia Vilchez authored and GitHub committed 2026-08-31 18:22:56 +02:00
1 parent 1871efba93
commit 4d368d7f1d
2 files changed
+24 -2

No files matched your search

+18 -2
View File
@@ -1592,7 +1592,16 @@ class TestAzureProviderCertificateAuth:
region_config=self._region_config(),
)
assert credentials["certificate_path"] == str(certificate_path)
# Assert the full contract, not just certificate_path — a stray
# truthy certificate_content or client_secret would route
# setup_session to the wrong branch and stay undetected.
assert credentials == {
"tenant_id": self._TENANT_ID,
"client_id": self._CLIENT_ID,
"client_secret": None,
"certificate_content": None,
"certificate_path": str(certificate_path),
}
def test_validate_static_credentials_accepts_valid_pkcs12_cert_file(self, tmp_path):
from cryptography.hazmat.primitives import serialization
@@ -1620,7 +1629,14 @@ class TestAzureProviderCertificateAuth:
region_config=self._region_config(),
)
assert credentials["certificate_path"] == str(certificate_path)
# Same rationale as the PEM test above: assert the full dict.
assert credentials == {
"tenant_id": self._TENANT_ID,
"client_id": self._CLIENT_ID,
"client_secret": None,
"certificate_content": None,
"certificate_path": str(certificate_path),
}
def test_setup_session_static_credentials_cert_content_uses_certificate_credential(
self,