From 57abe1c839f076df1bd9dacafd2c361bcffe18e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20Mart=C3=ADn?= Date: Thu, 19 Sep 2024 17:09:03 +0200 Subject: [PATCH] fix(accessanalyzer): refactor accessanalyzer enabled fixer test (#5026) --- .../accessanalyzer_enabled_fixer_test.py | 41 ++++++++++--------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/tests/providers/aws/services/accessanalyzer/accessanalyzer_enabled/accessanalyzer_enabled_fixer_test.py b/tests/providers/aws/services/accessanalyzer/accessanalyzer_enabled/accessanalyzer_enabled_fixer_test.py index c1f55114cc..ac600dc828 100644 --- a/tests/providers/aws/services/accessanalyzer/accessanalyzer_enabled/accessanalyzer_enabled_fixer_test.py +++ b/tests/providers/aws/services/accessanalyzer/accessanalyzer_enabled/accessanalyzer_enabled_fixer_test.py @@ -1,26 +1,29 @@ from unittest import mock -AWS_REGION = "eu-west-1" +from tests.providers.aws.utils import AWS_ACCOUNT_ARN, AWS_REGION_EU_WEST_1 class Test_accessanalyzer_enabled_fixer: - @mock.patch( - "prowler.providers.aws.services.accessanalyzer.accessanalyzer_enabled.accessanalyzer_enabled_fixer.accessanalyzer_client" - ) - def test_accessanalyzer_enabled_fixer(self, mock_accessanalyzer_client): - mock_client = mock.MagicMock() - mock_accessanalyzer_client.regional_clients = {AWS_REGION: mock_client} - mock_accessanalyzer_client.fixer_config = { - "accessanalyzer_enabled": { - "AnalyzerName": "DefaultAnalyzer", - "AnalyzerType": "ACCOUNT_UNUSED_ACCESS", - } - } - mock_client.create_analyzer.return_value = None + def test_accessanalyzer_enabled_fixer(self): + regional_client = mock.MagicMock() + accessanalyzer_client = mock.MagicMock() - from prowler.providers.aws.services.accessanalyzer.accessanalyzer_enabled.accessanalyzer_enabled_fixer import ( - fixer, - ) + accessanalyzer_client.region = AWS_REGION_EU_WEST_1 + accessanalyzer_client.analyzers = [] + accessanalyzer_client.audited_account_arn = AWS_ACCOUNT_ARN + regional_client.create_analyzer.return_value = None + accessanalyzer_client.regional_clients = {AWS_REGION_EU_WEST_1: regional_client} - result = fixer(AWS_REGION) - assert result + with mock.patch( + "prowler.providers.aws.services.accessanalyzer.accessanalyzer_service.AccessAnalyzer", + new=accessanalyzer_client, + ) as accessanalyzer_client, mock.patch( + "prowler.providers.aws.services.accessanalyzer.accessanalyzer_client.accessanalyzer_client", + new=accessanalyzer_client, + ): + # Test Check + from prowler.providers.aws.services.accessanalyzer.accessanalyzer_enabled.accessanalyzer_enabled_fixer import ( + fixer, + ) + + assert fixer(AWS_REGION_EU_WEST_1)