From 6b7ef199e086f05cd4a6ed7196fcdd38f628a453 Mon Sep 17 00:00:00 2001 From: Prowler Bot Date: Tue, 1 Apr 2025 21:23:16 +0200 Subject: [PATCH] fix(report): log as error when Resource ID or Name do not exist (#7412) Co-authored-by: Sergio Garcia --- prowler/lib/outputs/finding.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/prowler/lib/outputs/finding.py b/prowler/lib/outputs/finding.py index f41ed6d935..717783b75b 100644 --- a/prowler/lib/outputs/finding.py +++ b/prowler/lib/outputs/finding.py @@ -258,12 +258,21 @@ class Finding(BaseModel): # check_output Unique ID # TODO: move this to a function - # TODO: in Azure, GCP and K8s there are fidings without resource_name + # TODO: in Azure, GCP and K8s there are findings without resource_name output_data["uid"] = ( f"prowler-{provider.type}-{check_output.check_metadata.CheckID}-{output_data['account_uid']}-" f"{output_data['region']}-{output_data['resource_name']}" ) + if not output_data["resource_uid"]: + logger.error( + f"Check {check_output.check_metadata.CheckID} has no resource_id." + ) + if not output_data["resource_name"]: + logger.error( + f"Check {check_output.check_metadata.CheckID} has no resource_name." + ) + return cls(**output_data) except ValidationError as validation_error: logger.error(