From 717ec392805715a2a953c5c32bb216ed82b5f983 Mon Sep 17 00:00:00 2001 From: "Andoni A." <14891798+andoniaf@users.noreply.github.com> Date: Wed, 4 Mar 2026 12:25:59 +0100 Subject: [PATCH] fix(github): resolve flake8 errors and improve check metadata Fix E225 (missing whitespace around =) in provider.py and W292 (missing trailing newline) in check file. Update metadata CheckTitle to describe PASS state and Recommendation URL to point to Prowler Hub. --- prowler/providers/common/provider.py | 8 ++++---- ...anization_repository_deletion_limited.metadata.json | 6 +++--- .../organization_repository_deletion_limited.py | 10 +++------- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/prowler/providers/common/provider.py b/prowler/providers/common/provider.py index 3f65585413..d865449128 100644 --- a/prowler/providers/common/provider.py +++ b/prowler/providers/common/provider.py @@ -238,8 +238,8 @@ class Provider(ABC): fixer_config=fixer_config, ) elif "github" in provider_class_name.lower(): - orgs=[] - repos=[] + orgs = [] + repos = [] if getattr(arguments, "organization", None): orgs.extend(arguments.organization) @@ -250,8 +250,8 @@ class Provider(ABC): if getattr(arguments, "repositories", None): repos.extend(arguments.repositories) - orgs=list(dict.fromkeys(orgs)) - repos=list(dict.fromkeys(repos)) + orgs = list(dict.fromkeys(orgs)) + repos = list(dict.fromkeys(repos)) provider_class( personal_access_token=arguments.personal_access_token, diff --git a/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.metadata.json b/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.metadata.json index 387ad01b55..851848ce5a 100644 --- a/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.metadata.json +++ b/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.metadata.json @@ -1,7 +1,7 @@ { "Provider": "github", "CheckID": "organization_repository_deletion_limited", - "CheckTitle": "Ensure repository deletion is limited to trusted organization users", + "CheckTitle": "Organization repository deletion and transfer is restricted to owners", "CheckType": [], "ServiceName": "organization", "SubServiceName": "", @@ -21,7 +21,7 @@ }, "Recommendation": { "Text": "Disable member repository deletion/transfer privileges so only organization owners can delete or transfer repositories.", - "Url": "https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories" + "Url": "https://hub.prowler.com/check/organization_repository_deletion_limited" } }, "Categories": [ @@ -33,4 +33,4 @@ "AdditionalURLs": [ "https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories" ] -} \ No newline at end of file +} diff --git a/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.py b/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.py index d2ce513a28..5d94ad5af6 100644 --- a/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.py +++ b/prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.py @@ -21,15 +21,11 @@ class organization_repository_deletion_limited(Check): if members_can_delete is False: report.status = "PASS" - report.status_extended = ( - f"Organization {org.name} restricts repository deletion/transfer to trusted users." - ) + report.status_extended = f"Organization {org.name} restricts repository deletion/transfer to trusted users." else: report.status = "FAIL" - report.status_extended = ( - f"Organization {org.name} allows members to delete/transfer repositories." - ) + report.status_extended = f"Organization {org.name} allows members to delete/transfer repositories." findings.append(report) - return findings \ No newline at end of file + return findings