diff --git a/prowler/__main__.py b/prowler/__main__.py index 7a229112f3..e56b6ff957 100644 --- a/prowler/__main__.py +++ b/prowler/__main__.py @@ -135,7 +135,7 @@ def prowler(): sys.exit() # Load checks metadata - logger.debug("Loading checks metadata from .metadata.json files") + logger.debug("Loading checks metadata from .metadata.json files") bulk_checks_metadata = CheckMetadata.get_bulk(provider) if args.list_categories: diff --git a/prowler/lib/check/check.py b/prowler/lib/check/check.py index da11f231c8..1b02feff0b 100644 --- a/prowler/lib/check/check.py +++ b/prowler/lib/check/check.py @@ -14,7 +14,6 @@ from colorama import Fore, Style import prowler from prowler.config.config import orange_color -from prowler.lib.check.custom_checks_metadata import update_check_metadata from prowler.lib.check.models import Check from prowler.lib.check.utils import recover_checks_from_provider from prowler.lib.logger import logger @@ -474,7 +473,6 @@ def execute_checks( check_findings = execute( check, global_provider, - custom_checks_metadata, output_options, ) report(check_findings, global_provider, output_options) @@ -554,7 +552,6 @@ def execute_checks( check_findings = execute( check, global_provider, - custom_checks_metadata, output_options, ) @@ -602,7 +599,6 @@ def execute_checks( def execute( check: Check, global_provider: Any, - custom_checks_metadata: Any, output_options: Any = None, ): """ @@ -619,14 +615,6 @@ def execute( list: list of findings """ try: - # Update check metadata to reflect that in the outputs - if custom_checks_metadata and custom_checks_metadata["Checks"].get( - check.CheckID - ): - check = update_check_metadata( - check, custom_checks_metadata["Checks"][check.CheckID] - ) - only_logs = False if hasattr(output_options, "only_logs"): only_logs = output_options.only_logs diff --git a/prowler/lib/scan/scan.py b/prowler/lib/scan/scan.py index 48cd9335fb..bb71f304ac 100644 --- a/prowler/lib/scan/scan.py +++ b/prowler/lib/scan/scan.py @@ -1,6 +1,7 @@ from typing import Generator from prowler.lib.check.check import execute, import_check, update_audit_metadata +from prowler.lib.check.custom_checks_metadata import update_check_metadata from prowler.lib.logger import logger from prowler.lib.outputs.finding import Finding from prowler.providers.common.models import Audit_Metadata @@ -111,11 +112,18 @@ class Scan: f"Check '{check_name}' was not found for the {self._provider.type.upper()} provider" ) continue + + # Update check metadata to reflect that in the outputs + if custom_checks_metadata and custom_checks_metadata["Checks"].get( + check.CheckID + ): + check = update_check_metadata( + check, custom_checks_metadata["Checks"][check.CheckID] + ) # Execute the check check_findings = execute( check, self._provider, - custom_checks_metadata, output_options=None, )