From 74d6b614b3399a2e34ee288b16272f019dccae06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20De=20la=20Torre=20Vico?= Date: Thu, 16 Jan 2025 15:05:23 +0100 Subject: [PATCH] feat(iam): extract IAM resource metadata automated (#6552) --- ...tom_role_has_permissions_to_administer_resource_locks.py | 6 +++--- prowler/providers/azure/services/iam/iam_service.py | 1 - .../iam_subscription_roles_owner_custom_not_created.py | 6 +++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/prowler/providers/azure/services/iam/iam_custom_role_has_permissions_to_administer_resource_locks/iam_custom_role_has_permissions_to_administer_resource_locks.py b/prowler/providers/azure/services/iam/iam_custom_role_has_permissions_to_administer_resource_locks/iam_custom_role_has_permissions_to_administer_resource_locks.py index 751433a208..796f88c71c 100644 --- a/prowler/providers/azure/services/iam/iam_custom_role_has_permissions_to_administer_resource_locks/iam_custom_role_has_permissions_to_administer_resource_locks.py +++ b/prowler/providers/azure/services/iam/iam_custom_role_has_permissions_to_administer_resource_locks/iam_custom_role_has_permissions_to_administer_resource_locks.py @@ -13,10 +13,10 @@ class iam_custom_role_has_permissions_to_administer_resource_locks(Check): for custom_role in roles: if exits_role_with_permission_over_locks: break - report = Check_Report_Azure(self.metadata()) + report = Check_Report_Azure( + metadata=self.metadata(), resource_metadata=custom_role + ) report.subscription = subscription - report.resource_id = custom_role.id - report.resource_name = custom_role.name report.status = "FAIL" report.status_extended = f"Role {custom_role.name} from subscription {subscription} has no permission to administer resource locks." diff --git a/prowler/providers/azure/services/iam/iam_service.py b/prowler/providers/azure/services/iam/iam_service.py index 405650ce1c..30662295db 100644 --- a/prowler/providers/azure/services/iam/iam_service.py +++ b/prowler/providers/azure/services/iam/iam_service.py @@ -8,7 +8,6 @@ from prowler.providers.azure.azure_provider import AzureProvider from prowler.providers.azure.lib.service.service import AzureService -########################## IAM class IAM(AzureService): def __init__(self, provider: AzureProvider): super().__init__(AuthorizationManagementClient, provider) diff --git a/prowler/providers/azure/services/iam/iam_subscription_roles_owner_custom_not_created/iam_subscription_roles_owner_custom_not_created.py b/prowler/providers/azure/services/iam/iam_subscription_roles_owner_custom_not_created/iam_subscription_roles_owner_custom_not_created.py index 3fbcce9264..a804d749c2 100644 --- a/prowler/providers/azure/services/iam/iam_subscription_roles_owner_custom_not_created/iam_subscription_roles_owner_custom_not_created.py +++ b/prowler/providers/azure/services/iam/iam_subscription_roles_owner_custom_not_created/iam_subscription_roles_owner_custom_not_created.py @@ -9,10 +9,10 @@ class iam_subscription_roles_owner_custom_not_created(Check): findings = [] for subscription, roles in iam_client.custom_roles.items(): for custom_role in roles: - report = Check_Report_Azure(self.metadata()) + report = Check_Report_Azure( + metadata=self.metadata(), resource_metadata=custom_role + ) report.subscription = subscription - report.resource_id = custom_role.id - report.resource_name = custom_role.name report.status = "PASS" report.status_extended = f"Role {custom_role.name} from subscription {subscription} is not a custom owner role." for scope in custom_role.assignable_scopes: