From 75d66df94061d5cbc738384e74f0a3f42d0d6b37 Mon Sep 17 00:00:00 2001 From: Nimrod Kor Date: Sun, 22 Mar 2020 11:00:02 +0200 Subject: [PATCH] extra774 - check correct date, consolidate files and fix report generation --- checks/check_extra774 | 2 +- checks/check_extra_774 | 21 --------------------- prowler | 2 +- 3 files changed, 2 insertions(+), 23 deletions(-) delete mode 100644 checks/check_extra_774 diff --git a/checks/check_extra774 b/checks/check_extra774 index 83e2aa6fc3..d8dae7a447 100644 --- a/checks/check_extra774 +++ b/checks/check_extra774 @@ -21,7 +21,7 @@ extra774(){ LIST_USERS_WITH_PASSWORD_ENABLED=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$4,$5 }' |grep true | awk '{ print $1 }') for i in $LIST_USERS_WITH_PASSWORD_ENABLED; do - user=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$5 }' |grep "^$i " |awk '{ print $1 }') + user=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$3 }' |grep "^$i " |awk '{ print $1 }') last_login_date=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$5 }' |grep "^$i " |awk '{ print $2 }') days_not_in_use=$(how_many_days_from_today ${last_login_date%T*}) diff --git a/checks/check_extra_774 b/checks/check_extra_774 deleted file mode 100644 index 984b0dec6e..0000000000 --- a/checks/check_extra_774 +++ /dev/null @@ -1,21 +0,0 @@ -CHECK_ID_extra774="1.23" -CHECK_TITLE_extra774="[extra774] Check if user have unused console login" -CHECK_SCORED_extra774="NOT_SCORED" -CHECK_TYPE_extra774="EXTRA" -CHECK_ALTERNATE_check774="extra774" -MAX_DAYS=-30 -extra774(){ - LIST_USERS_WITH_PASSWORD_ENABLED=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$4,$5 }' |grep true | awk '{ print $1 }') - - for i in $LIST_USERS_WITH_PASSWORD_ENABLED; do - user=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$3 }' |grep "^$i " |awk '{ print $1 }') - last_login_date=$(cat $TEMP_REPORT_FILE|awk -F, '{ print $1,$3 }' |grep "^$i " |awk '{ print $2 }') - - days_not_in_use=$(how_many_days_from_today ${last_login_date%T*}) - if [ "$days_not_in_use" -lt "$MAX_DAYS" ];then - textFail "User $user has not used console login for more then ${MAX_DAYS#-} days" - else - textPass "User $user has used console login in the past ${MAX_DAYS#-} days" - fi - done -} \ No newline at end of file diff --git a/prowler b/prowler index a3a8db27ce..0310a19731 100755 --- a/prowler +++ b/prowler @@ -260,7 +260,7 @@ execute_check() { local check_id_var=CHECK_ID_$1 local check_id=${!check_id_var} if [ ${check_id} ]; then - if [[ ${check_id} == 1* || ${check_id} == 7.1,7.01 ]];then + if [[ ${check_id} == 1* || ${check_id} == 7.1,7.01 || ${check_id} == 7.74 ]];then if [ ! -s $TEMP_REPORT_FILE ];then genCredReport saveReport