From 8d1356a085666418f1327644ea9feb9eb3202ed6 Mon Sep 17 00:00:00 2001 From: Sergio Garcia <38561120+sergargar@users.noreply.github.com> Date: Mon, 10 Apr 2023 08:02:40 +0200 Subject: [PATCH] fix(logging): add default resource id when no resources (#2177) --- ..._filter_and_alert_for_audit_configuration_changes_enabled.py | 2 +- ...ic_filter_and_alert_for_bucket_permission_changes_enabled.py | 2 +- ...g_metric_filter_and_alert_for_custom_role_changes_enabled.py | 2 +- ...ic_filter_and_alert_for_project_ownership_changes_enabled.py | 2 +- ..._and_alert_for_sql_instance_configuration_changes_enabled.py | 2 +- ...ic_filter_and_alert_for_vpc_firewall_rule_changes_enabled.py | 2 +- ...g_metric_filter_and_alert_for_vpc_network_changes_enabled.py | 2 +- ...ic_filter_and_alert_for_vpc_network_route_changes_enabled.py | 2 +- .../logging/logging_sink_created/logging_sink_created.py | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled.py index a00ba3118b..bf3bc1507d 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_audit_configuration_changes_enabled.py @@ -12,7 +12,7 @@ class logging_log_metric_filter_and_alert_for_audit_configuration_changes_enable findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled.py index 0f89bdb42b..951fb0e879 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled/logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_bucket_permission_changes_enabled( findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled.py index 6344595211..501b3972f4 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled/logging_log_metric_filter_and_alert_for_custom_role_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_custom_role_changes_enabled(Check) findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled.py index a85d88650d..3084d4810c 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled/logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_project_ownership_changes_enabled( findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled.py index c77a0b1246..6d87740db7 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled/logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled.py @@ -12,7 +12,7 @@ class logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled.py index 68e90f0af8..80a09ddb18 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_vpc_firewall_rule_changes_enabled( findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled.py index 852cf62a9b..9048778e6a 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_vpc_network_changes_enabled(Check) findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled.py b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled.py index 0d962fc88b..c7a4357628 100644 --- a/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled.py +++ b/prowler/providers/gcp/services/logging/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled/logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled.py @@ -10,7 +10,7 @@ class logging_log_metric_filter_and_alert_for_vpc_network_route_changes_enabled( findings = [] report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL" diff --git a/prowler/providers/gcp/services/logging/logging_sink_created/logging_sink_created.py b/prowler/providers/gcp/services/logging/logging_sink_created/logging_sink_created.py index 2ac70f4366..be4eb442fe 100644 --- a/prowler/providers/gcp/services/logging/logging_sink_created/logging_sink_created.py +++ b/prowler/providers/gcp/services/logging/logging_sink_created/logging_sink_created.py @@ -8,7 +8,7 @@ class logging_sink_created(Check): if not logging_client.sinks: report = Check_Report_GCP(self.metadata()) report.project_id = logging_client.project_id - report.resource_id = "" + report.resource_id = logging_client.project_id report.resource_name = "" report.location = logging_client.region report.status = "FAIL"