feat(elb): add new check elb_connection_draining_enabled (#5014)

Co-authored-by: Sergio <sergio@prowler.com>

tests/providers/aws/services/elb/elb_connection_draining_enabled/elb_connection_draining_enabled_test.py

@@ -0,0 +1,145 @@
+from unittest import mock
+
+from boto3 import client
+from moto import mock_aws
+
+from tests.providers.aws.utils import (
+    AWS_ACCOUNT_NUMBER,
+    AWS_REGION_EU_WEST_1,
+    set_mocked_aws_provider,
+)
+
+
+class Test_elb_connection_draining_enabled:
+
+    def test_elb_no_balancers(self):
+        from prowler.providers.aws.services.elb.elb_service import ELB
+
+        with mock.patch(
+            "prowler.providers.common.provider.Provider.get_global_provider",
+            return_value=set_mocked_aws_provider([AWS_REGION_EU_WEST_1]),
+        ), mock.patch(
+            "prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled.elb_client",
+            new=ELB(set_mocked_aws_provider([AWS_REGION_EU_WEST_1])),
+        ):
+            # Test Check
+            from prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled import (
+                elb_connection_draining_enabled,
+            )
+
+            check = elb_connection_draining_enabled()
+            result = check.execute()
+
+            assert len(result) == 0
+
+    @mock_aws
+    def test_elb_draining_connection_enabled(self):
+        elb_client = client("elb", region_name=AWS_REGION_EU_WEST_1)
+        # Create a compliant resource
+
+        elb_client.create_load_balancer(
+            LoadBalancerName="my-lb",
+            Listeners=[
+                {"Protocol": "tcp", "LoadBalancerPort": 80, "InstancePort": 8080},
+                {"Protocol": "http", "LoadBalancerPort": 81, "InstancePort": 9000},
+            ],
+            Scheme="internet-facing",
+        )
+
+        elb_client.modify_load_balancer_attributes(
+            LoadBalancerName="my-lb",
+            LoadBalancerAttributes={
+                "ConnectionDraining": {
+                    "Enabled": True,
+                    "Timeout": 60,
+                }
+            },
+        )
+
+        from prowler.providers.aws.services.elb.elb_service import ELB
+
+        aws_provider = set_mocked_aws_provider([AWS_REGION_EU_WEST_1])
+
+        with mock.patch(
+            "prowler.providers.common.provider.Provider.get_global_provider",
+            return_value=aws_provider,
+        ), mock.patch(
+            "prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled.elb_client",
+            new=ELB(aws_provider),
+        ):
+            from prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled import (
+                elb_connection_draining_enabled,
+            )
+
+            check = elb_connection_draining_enabled()
+            result = check.execute()
+
+            assert len(result) == 1
+            assert result[0].status == "PASS"
+            assert (
+                result[0].status_extended
+                == "ELB my-lb has connection draining enabled."
+            )
+            assert result[0].region == AWS_REGION_EU_WEST_1
+            assert result[0].resource_id == "my-lb"
+            assert (
+                result[0].resource_arn
+                == f"arn:aws:elasticloadbalancing:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+            )
+            assert result[0].resource_tags == []
+
+    @mock_aws
+    def test_elb_draining_connection_disabled(self):
+        elb_client = client("elb", region_name=AWS_REGION_EU_WEST_1)
+        # Create a compliant resource
+
+        elb_client.create_load_balancer(
+            LoadBalancerName="my-lb",
+            Listeners=[
+                {"Protocol": "tcp", "LoadBalancerPort": 80, "InstancePort": 8080},
+                {"Protocol": "http", "LoadBalancerPort": 81, "InstancePort": 9000},
+            ],
+            Scheme="internet-facing",
+        )
+
+        elb_client.modify_load_balancer_attributes(
+            LoadBalancerName="my-lb",
+            LoadBalancerAttributes={
+                "ConnectionDraining": {
+                    "Enabled": False,
+                    "Timeout": 60,
+                }
+            },
+        )
+
+        from prowler.providers.aws.services.elb.elb_service import ELB
+
+        aws_provider = set_mocked_aws_provider([AWS_REGION_EU_WEST_1])
+
+        with mock.patch(
+            "prowler.providers.common.provider.Provider.get_global_provider",
+            return_value=aws_provider,
+        ), mock.patch(
+            "prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled.elb_client",
+            new=ELB(aws_provider),
+        ):
+            from prowler.providers.aws.services.elb.elb_connection_draining_enabled.elb_connection_draining_enabled import (
+                elb_connection_draining_enabled,
+            )
+
+            check = elb_connection_draining_enabled()
+            result = check.execute()
+
+            assert len(result) == 1
+            assert result[0].status == "FAIL"
+            assert (
+                result[0].status_extended
+                == "ELB my-lb does not have connection draining enabled."
+            )
+            assert result[0].region == AWS_REGION_EU_WEST_1
+            assert result[0].resource_id == "my-lb"
+            assert (
+                result[0].resource_arn
+                == f"arn:aws:elasticloadbalancing:{AWS_REGION_EU_WEST_1}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+            )
+            assert result[0].resource_tags == []

tests/providers/aws/services/elb/elb_service_test.py

@@ -104,6 +104,7 @@ class Test_ELB_Service:
                     "S3BucketPrefix": "s3bf",
                 },
                 "CrossZoneLoadBalancing": {"Enabled": True},
+                "ConnectionDraining": {"Enabled": True, "Timeout": 60},
             },
         )
         elb_arn = f"arn:aws:elasticloadbalancing:{AWS_REGION_US_EAST_1}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
@@ -115,6 +116,7 @@ class Test_ELB_Service:
         assert elb.loadbalancers[elb_arn].scheme == "internal"
         assert elb.loadbalancers[elb_arn].access_logs
         assert elb.loadbalancers[elb_arn].cross_zone_load_balancing
+        assert elb.loadbalancers[elb_arn].connection_draining
 
     # Test ELB Describe Tags
     @mock_aws