From 92e0d740557ef4fe438e7a692df911047f40b2a8 Mon Sep 17 00:00:00 2001 From: Fennerr Date: Wed, 13 Dec 2023 14:51:17 +0200 Subject: [PATCH] Keeping the code seperate from the function obj --- .../awslambda_function_no_secrets_in_code.py | 6 +++--- .../providers/aws/services/awslambda/awslambda_service.py | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/prowler/providers/aws/services/awslambda/awslambda_function_no_secrets_in_code/awslambda_function_no_secrets_in_code.py b/prowler/providers/aws/services/awslambda/awslambda_function_no_secrets_in_code/awslambda_function_no_secrets_in_code.py index 8ef976e818..1e42b66eef 100644 --- a/prowler/providers/aws/services/awslambda/awslambda_function_no_secrets_in_code/awslambda_function_no_secrets_in_code.py +++ b/prowler/providers/aws/services/awslambda/awslambda_function_no_secrets_in_code/awslambda_function_no_secrets_in_code.py @@ -12,8 +12,8 @@ class awslambda_function_no_secrets_in_code(Check): def execute(self): findings = [] if awslambda_client.functions: - for function in awslambda_client.__get_function_code__(): - if function.code: + for function_code, function in awslambda_client.__get_function_code__(): + if function_code: report = Check_Report_AWS(self.metadata()) report.region = function.region report.resource_id = function.name @@ -25,7 +25,7 @@ class awslambda_function_no_secrets_in_code(Check): f"No secrets found in Lambda function {function.name} code." ) with tempfile.TemporaryDirectory() as tmp_dir_name: - function.code.code_zip.extractall(tmp_dir_name) + function_code.code_zip.extractall(tmp_dir_name) # List all files files_in_zip = next(os.walk(tmp_dir_name))[2] secrets_findings = [] diff --git a/prowler/providers/aws/services/awslambda/awslambda_service.py b/prowler/providers/aws/services/awslambda/awslambda_service.py index c2cd750185..60d08edeac 100644 --- a/prowler/providers/aws/services/awslambda/awslambda_service.py +++ b/prowler/providers/aws/services/awslambda/awslambda_service.py @@ -77,8 +77,7 @@ class Lambda(AWSService): try: function_code = fetched_lambda_code.result() if function_code: - function.code = function_code - yield function + yield function_code, function except Exception as error: logger.error( f"{function.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"