diff --git a/.github/workflows/ui-e2e-tests-v2.yml b/.github/workflows/ui-e2e-tests-v2.yml index 2bf6db8a5a..8cf43f9d66 100644 --- a/.github/workflows/ui-e2e-tests-v2.yml +++ b/.github/workflows/ui-e2e-tests-v2.yml @@ -11,6 +11,7 @@ on: - "v5.*" paths: - ".github/workflows/ui-e2e-tests-v2.yml" + - ".github/workflows/test-impact-analysis.yml" - ".github/test-impact.yml" - "ui/**" - "api/**" # API changes can affect UI E2E @@ -237,8 +238,8 @@ jobs: - name: Add AWS credentials for testing run: | - echo "AWS_ACCESS_KEY_ID=${{ secrets.E2E_AWS_PROVIDER_ACCESS_KEY }}" >> .env - echo "AWS_SECRET_ACCESS_KEY=${{ secrets.E2E_AWS_PROVIDER_SECRET_KEY }}" >> .env + echo "AWS_ACCESS_KEY_ID=${E2E_AWS_PROVIDER_ACCESS_KEY}" >> .env + echo "AWS_SECRET_ACCESS_KEY=${E2E_AWS_PROVIDER_SECRET_KEY}" >> .env - name: Build API image from current code # docker-compose.yml references prowlercloud/prowler-api:latest from the registry, diff --git a/prowler/changelog.d/ui-e2e-secrets-via-env.security.md b/prowler/changelog.d/ui-e2e-secrets-via-env.security.md new file mode 100644 index 0000000000..476f690e3c --- /dev/null +++ b/prowler/changelog.d/ui-e2e-secrets-via-env.security.md @@ -0,0 +1 @@ +Pass the E2E AWS credentials to the UI E2E workflow through environment variables instead of template expansion