From 9e90bde554ecfc68c2b85f7e8f2a7c7470b0a1b7 Mon Sep 17 00:00:00 2001
From: Toni de la Fuente <toni@blyx.com>
Date: Thu, 6 Jan 2022 13:12:24 +0100
Subject: [PATCH] Changed Route53 checks 7152 and 7153 title to clarify

---
 checks/check_extra7152 | 11 ++++++-----
 checks/check_extra7153 |  8 ++++----
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/checks/check_extra7152 b/checks/check_extra7152
index 97ddb19808..136a332e1f 100644
--- a/checks/check_extra7152
+++ b/checks/check_extra7152
@@ -23,7 +23,7 @@
 #   --tech-privacy
 
 CHECK_ID_extra7152="7.152"
-CHECK_TITLE_extra7152="[extra7152] Enable Privacy Protection for for a Route53 Domain"
+CHECK_TITLE_extra7152="[extra7152] Enable Privacy Protection for for a Route53 Domain (us-east-1 only)"
 CHECK_SCORED_extra7152="NOT_SCORED"
 CHECK_CIS_LEVEL_extra7152="EXTRA"
 CHECK_SEVERITY_extra7152="Medium"
@@ -36,18 +36,19 @@ CHECK_DOC_extra7152='https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/d
 CHECK_CAF_EPIC_extra7152='Data Protection'
 
 extra7152(){
-    # echo "Route53 is a global service, looking for domains in US-EAST-1"
+    # Route53 is a global service, looking for domains in US-EAST-1
+    # this is also valid for GovCloud https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/setting-up-route53.html
     DOMAIN_NAMES=$($AWSCLI route53domains list-domains $PROFILE_OPT --region us-east-1 --query 'Domains[*].DomainName' --output text )
     if [[ $DOMAIN_NAMES ]];then
       for domain_name in $DOMAIN_NAMES;do
         DOMAIN_DETAIL=$($AWSCLI route53domains get-domain-detail $PROFILE_OPT --region us-east-1 --query 'AdminPrivacy' --domain-name $domain_name)
         if [[ $DOMAIN_DETAIL == false ]]; then
-          textFail "$regx: Contact information public for: $domain_name" "$regx" "$domain_name"
+          textFail "us-east-1: Contact information public for: $domain_name" "us-east-1" "$domain_name"
           else
-          textPass "$regx: All contact information is private for: $domain_name" "$regx" "$domain_name"
+          textPass "us-east-1: All contact information is private for: $domain_name" "us-east-1" "$domain_name"
         fi
       done
       else
-      textInfo "$regx: No Domain Names found" "$regx"
+      textInfo "us-east-1: No Domain Names found" "us-east-1"
     fi
 }
diff --git a/checks/check_extra7153 b/checks/check_extra7153
index c0a054bc81..e7f31b2bdf 100644
--- a/checks/check_extra7153
+++ b/checks/check_extra7153
@@ -20,7 +20,7 @@
 
 
 CHECK_ID_extra7153="7.153"
-CHECK_TITLE_extra7153="[extra7153] Enable Transfer Lock for a Route53 Domain"
+CHECK_TITLE_extra7153="[extra7153] Enable Transfer Lock for a Route53 Domain (us-east-1 only)"
 CHECK_SCORED_extra7153="NOT_SCORED"
 CHECK_CIS_LEVEL_extra7153="EXTRA"
 CHECK_SEVERITY_extra7153="Medium"
@@ -41,12 +41,12 @@ extra7153(){
         DOMAIN_DETAIL=$($AWSCLI route53domains get-domain-detail $PROFILE_OPT --region us-east-1 --query 'StatusList' --domain-name $domain_name)
         HAS_TRANSFER_LOCK=$( grep -o 'clientTransferProhibited' <<< $DOMAIN_DETAIL)
         if [[ $HAS_TRANSFER_LOCK ]]; then
-          textPass "$regx: clientTransferProhibited found for: $domain_name" "$regx" "$domain_name"
+          textPass "us-east-1: clientTransferProhibited found for: $domain_name" "us-east-1" "$domain_name"
           else
-          textFail "$regx: clientTransferProhibited not found for: $domain_name" "$regx" "$domain_name"
+          textFail "us-east-1: clientTransferProhibited not found for: $domain_name" "us-east-1" "$domain_name"
         fi
       done
       else
-      textInfo "$regx: No Domain Names found" "$regx"
+      textInfo "us-east-1: No Domain Names found" "us-east-1"
     fi
 }