From a424374c44b3ffd779f2c5d5f296985650f0af3b Mon Sep 17 00:00:00 2001 From: Prowler Bot Date: Wed, 19 Feb 2025 03:38:31 +0100 Subject: [PATCH] fix(cloudfront): Incorrect bucket name retrievement (#6967) Co-authored-by: Hugo Pereira Brito <101209179+HugoPBrito@users.noreply.github.com> --- .../cloudfront_distributions_s3_origin_non_existent_bucket.py | 2 +- prowler/providers/aws/services/s3/s3_service.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/prowler/providers/aws/services/cloudfront/cloudfront_distributions_s3_origin_non_existent_bucket/cloudfront_distributions_s3_origin_non_existent_bucket.py b/prowler/providers/aws/services/cloudfront/cloudfront_distributions_s3_origin_non_existent_bucket/cloudfront_distributions_s3_origin_non_existent_bucket.py index a9da703239..ea932ba027 100644 --- a/prowler/providers/aws/services/cloudfront/cloudfront_distributions_s3_origin_non_existent_bucket/cloudfront_distributions_s3_origin_non_existent_bucket.py +++ b/prowler/providers/aws/services/cloudfront/cloudfront_distributions_s3_origin_non_existent_bucket/cloudfront_distributions_s3_origin_non_existent_bucket.py @@ -16,7 +16,7 @@ class cloudfront_distributions_s3_origin_non_existent_bucket(Check): for origin in distribution.origins: if origin.s3_origin_config: - bucket_name = origin.domain_name.split(".")[0] + bucket_name = origin.domain_name.split(".s3")[0] if not s3_client._head_bucket(bucket_name): non_existent_buckets.append(bucket_name) diff --git a/prowler/providers/aws/services/s3/s3_service.py b/prowler/providers/aws/services/s3/s3_service.py index 8939da0987..3894e1001d 100644 --- a/prowler/providers/aws/services/s3/s3_service.py +++ b/prowler/providers/aws/services/s3/s3_service.py @@ -496,6 +496,7 @@ class S3(AWSService): ) return False else: + # Bucket exists but we don't have access to it logger.error( f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" )