From a97fb3d9930325edc20528ad6be52d3bb3897915 Mon Sep 17 00:00:00 2001 From: HugoPBrito Date: Fri, 7 Nov 2025 13:58:26 +0000 Subject: [PATCH] fix: unused parameter --- prowler/providers/m365/lib/powershell/m365_powershell.py | 3 +-- .../providers/m365/lib/powershell/m365_powershell_test.py | 7 ++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/prowler/providers/m365/lib/powershell/m365_powershell.py b/prowler/providers/m365/lib/powershell/m365_powershell.py index 5dbf2a59c8..797fd667ce 100644 --- a/prowler/providers/m365/lib/powershell/m365_powershell.py +++ b/prowler/providers/m365/lib/powershell/m365_powershell.py @@ -1,5 +1,4 @@ import os -from typing import Optional from prowler.lib.logger import logger from prowler.lib.powershell.powershell import PowerShellSession @@ -124,7 +123,7 @@ class M365PowerShell(PowerShellSession): '$graphToken = Invoke-RestMethod -Uri "https://login.microsoftonline.com/$tenantID/oauth2/v2.0/token" -Method POST -Body $graphtokenBody | Select-Object -ExpandProperty Access_Token' ) - def execute_connect(self, command: str, timeout: Optional[int] = None) -> str: + def execute_connect(self, command: str) -> str: """ Execute a PowerShell connect command ensuring empty responses surface as timeouts. diff --git a/tests/providers/m365/lib/powershell/m365_powershell_test.py b/tests/providers/m365/lib/powershell/m365_powershell_test.py index 531dd8a91f..28b09768c3 100644 --- a/tests/providers/m365/lib/powershell/m365_powershell_test.py +++ b/tests/providers/m365/lib/powershell/m365_powershell_test.py @@ -566,7 +566,7 @@ class Testm365PowerShell: ) session = M365PowerShell(credentials, identity) - session.execute = MagicMock(return_value=None) + session.execute = MagicMock(side_effect=[None, ""]) session.execute_connect = MagicMock(return_value="") result = session.test_teams_connection() @@ -598,8 +598,8 @@ class Testm365PowerShell: ) session = M365PowerShell(credentials, identity) - session.execute = MagicMock(return_value=None) - session.execute_connect = MagicMock(return_value="Permission denied") + session.execute = MagicMock(side_effect=[None, "Permission denied"]) + session.execute_connect = MagicMock() with patch("prowler.lib.logger.logger.error") as mock_error: result = session.test_teams_connection() @@ -608,6 +608,7 @@ class Testm365PowerShell: mock_error.assert_called_once_with( "Microsoft Teams connection failed: Permission denied" ) + session.execute_connect.assert_not_called() session.close() @patch("subprocess.Popen")