ben.carrasco/prowler
1
0 Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-10-29 14:54:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(arn): refactor arn for unknown resources (#5712)

Browse Source 
Co-authored-by: Sergio Garcia <hello@mistercloudsec.com>
This commit is contained in:
Pedro MartínandSergio Garcia authored and GitHub committed 2024-11-19 16:21:43 -04:00
1 parent a5f5967bb2
commit b06e549d81
22 files changed
+267 -92
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/providers/aws/services/securityhub/securityhub_enabled/securityhub_enabled_test.py
+16 -3
View File
@@ -3,16 +3,19 @@ from unittest import mock
from prowler.providers.aws.services.securityhub.securityhub_service import (
SecurityHubHub,
)
from tests.providers.aws.utils import AWS_ACCOUNT_ARN, AWS_REGION_EU_WEST_1
from tests.providers.aws.utils import AWS_REGION_EU_WEST_1
class Test_securityhub_enabled:
def test_securityhub_hub_inactive(self):
securityhub_client = mock.MagicMock
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.get_unknown_arn = (
lambda x: f"arn:aws:securityhub:{x}:0123456789012:unknown"
)
securityhub_client.securityhubs = [
SecurityHubHub(
arn=AWS_ACCOUNT_ARN,
arn=f"arn:aws:securityhub:{AWS_REGION_EU_WEST_1}:0123456789012:unknown",
id="Security Hub",
status="NOT_AVAILABLE",
standards="",
@@ -24,6 +27,9 @@ class Test_securityhub_enabled:
with mock.patch(
"prowler.providers.aws.services.securityhub.securityhub_service.SecurityHub",
new=securityhub_client,
), mock.patch(
"prowler.providers.aws.services.securityhub.securityhub_service.SecurityHub.get_unknown_arn",
return_value="arn:aws:securityhub:eu-west-1:0123456789012:unknown",
):
# Test Check
from prowler.providers.aws.services.securityhub.securityhub_enabled.securityhub_enabled import (
@@ -36,7 +42,10 @@ class Test_securityhub_enabled:
assert result[0].status == "FAIL"
assert result[0].status_extended == "Security Hub is not enabled."
assert result[0].resource_id == "Security Hub"
assert result[0].resource_arn == AWS_ACCOUNT_ARN
assert (
result[0].resource_arn
== "arn:aws:securityhub:eu-west-1:0123456789012:unknown"
)
assert result[0].region == AWS_REGION_EU_WEST_1
assert result[0].resource_tags == [{"test_key": "test_value"}]
@@ -119,6 +128,8 @@ class Test_securityhub_enabled:
def test_securityhub_hub_active_without_integrations_or_standards(self):
securityhub_client = mock.MagicMock
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.audited_partition = "aws"
securityhub_client.audited_account = "0123456789012"
securityhub_client.securityhubs = [
SecurityHubHub(
arn="arn:aws:securityhub:us-east-1:0123456789012:hub/default",
@@ -159,6 +170,8 @@ class Test_securityhub_enabled:
securityhub_client = mock.MagicMock
securityhub_client.audit_config = {"mute_non_default_regions": True}
securityhub_client.region = AWS_REGION_EU_WEST_1
securityhub_client.audited_partition = "aws"
securityhub_client.audited_account = "0123456789012"
securityhub_client.securityhubs = [
SecurityHubHub(
arn="arn:aws:securityhub:us-east-1:0123456789012:hub/default",