From b1de41619b1700c548f12cfc55435196c631addd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20De=20la=20Torre=20Vico?= Date: Fri, 17 Jan 2025 14:16:43 +0100 Subject: [PATCH] fix: add missing Check_Report_Azure parameters (#6583) --- ...nditional_access_policy_require_mfa_for_management_api.py | 5 ++++- .../entra_non_privileged_user_has_mfa.py | 4 +++- .../monitor_diagnostic_settings_exists.py | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/prowler/providers/azure/services/entra/entra_conditional_access_policy_require_mfa_for_management_api/entra_conditional_access_policy_require_mfa_for_management_api.py b/prowler/providers/azure/services/entra/entra_conditional_access_policy_require_mfa_for_management_api/entra_conditional_access_policy_require_mfa_for_management_api.py index 8c76f4d9fd..ce113af7a4 100644 --- a/prowler/providers/azure/services/entra/entra_conditional_access_policy_require_mfa_for_management_api/entra_conditional_access_policy_require_mfa_for_management_api.py +++ b/prowler/providers/azure/services/entra/entra_conditional_access_policy_require_mfa_for_management_api/entra_conditional_access_policy_require_mfa_for_management_api.py @@ -32,7 +32,10 @@ class entra_conditional_access_policy_require_mfa_for_management_api(Check): ) break else: - report = Check_Report_Azure(self.metadata()) + report = Check_Report_Azure( + metadata=self.metadata(), + resource_metadata=conditional_access_policies.values(), + ) report.subscription = f"Tenant: {tenant_name}" report.resource_name = "Conditional Access Policy" report.resource_id = "Conditional Access Policy" diff --git a/prowler/providers/azure/services/entra/entra_non_privileged_user_has_mfa/entra_non_privileged_user_has_mfa.py b/prowler/providers/azure/services/entra/entra_non_privileged_user_has_mfa/entra_non_privileged_user_has_mfa.py index 8603fbb00a..11d98e4ba7 100644 --- a/prowler/providers/azure/services/entra/entra_non_privileged_user_has_mfa/entra_non_privileged_user_has_mfa.py +++ b/prowler/providers/azure/services/entra/entra_non_privileged_user_has_mfa/entra_non_privileged_user_has_mfa.py @@ -14,7 +14,9 @@ class entra_non_privileged_user_has_mfa(Check): if not is_privileged_user( user, entra_client.directory_roles[tenant_domain] ): - report = Check_Report_Azure(self.metadata(), resource_metadata=user) + report = Check_Report_Azure( + metadata=self.metadata(), resource_metadata=user + ) report.subscription = f"Tenant: {tenant_domain}" report.status = "FAIL" report.status_extended = ( diff --git a/prowler/providers/azure/services/monitor/monitor_diagnostic_settings_exists/monitor_diagnostic_settings_exists.py b/prowler/providers/azure/services/monitor/monitor_diagnostic_settings_exists/monitor_diagnostic_settings_exists.py index ff08b7c76d..7e0100d8c2 100644 --- a/prowler/providers/azure/services/monitor/monitor_diagnostic_settings_exists/monitor_diagnostic_settings_exists.py +++ b/prowler/providers/azure/services/monitor/monitor_diagnostic_settings_exists/monitor_diagnostic_settings_exists.py @@ -10,7 +10,9 @@ class monitor_diagnostic_settings_exists(Check): subscription_name, diagnostic_settings, ) in monitor_client.diagnostics_settings.items(): - report = Check_Report_Azure(self.metadata(), diagnostic_settings) + report = Check_Report_Azure( + metadata=self.metadata(), resource_metadata=diagnostic_settings + ) report.subscription = subscription_name report.resource_name = "Diagnostic Settings" report.resource_id = "diagnostic_settings"