From b27155790ef40c3f4872dd2e457f7adb62df3e72 Mon Sep 17 00:00:00 2001
From: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Date: Mon, 27 May 2024 10:03:12 -0400
Subject: [PATCH] fix(rds): solve ParameterValue KeyError (#4085)

---
 .../rds_instance_transport_encrypted.py                       | 4 ++--
 .../rds_instance_transport_encrypted_test.py                  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py b/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py
index 6744190a4f..b51748213d 100644
--- a/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py
+++ b/prowler/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py
@@ -42,7 +42,7 @@ class rds_instance_transport_encrypted(Check):
                     for parameter in db_instance.parameters:
                         if (
                             parameter["ParameterName"] == "rds.force_ssl"
-                            and parameter["ParameterValue"] == "1"
+                            and parameter.get("ParameterValue", "0") == "1"
                         ):
                             report.status = "PASS"
                             report.status_extended = f"RDS Instance {db_instance.id} connections use SSL encryption."
@@ -50,7 +50,7 @@ class rds_instance_transport_encrypted(Check):
                     for parameter in db_instance.parameters:
                         if (
                             parameter["ParameterName"] == "require_secure_transport"
-                            and parameter["ParameterValue"] == "1"
+                            and parameter.get("ParameterValue", "OFF") == "ON"
                         ):
                             report.status = "PASS"
                             report.status_extended = f"RDS Instance {db_instance.id} connections use SSL encryption."
diff --git a/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py b/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py
index fd07dffae6..fc73bf1a72 100644
--- a/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py
+++ b/tests/providers/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted_test.py
@@ -250,7 +250,7 @@ class Test_rds_instance_transport_encrypted:
             Parameters=[
                 {
                     "ParameterName": "require_secure_transport",
-                    "ParameterValue": "0",
+                    "ParameterValue": "OFF",
                     "ApplyMethod": "immediate",
                 },
             ],
@@ -312,7 +312,7 @@ class Test_rds_instance_transport_encrypted:
             Parameters=[
                 {
                     "ParameterName": "require_secure_transport",
-                    "ParameterValue": "1",
+                    "ParameterValue": "ON",
                     "ApplyMethod": "immediate",
                 },
             ],