From bd56ca2979d7d127adaaf24bb0e5afb6e77348dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20De=20la=20Torre=20Vico?= Date: Tue, 23 Jul 2024 12:41:07 +0200 Subject: [PATCH] chore(dms): Change checks IDs to match with metadata (#4520) --- .../__init__.py | 0 ...ms_instance_multi_az_enabled.metadata.json} | 0 .../dms_instance_multi_az_enabled.py} | 2 +- ...dms_instance_no_public_access.metadata.json | 2 +- .../dms_instance_multi_az_test.py | 18 +++++++++--------- 5 files changed, 11 insertions(+), 11 deletions(-) rename prowler/providers/aws/services/dms/{dms_instance_multi_az => dms_instance_multi_az_enabled}/__init__.py (100%) rename prowler/providers/aws/services/dms/{dms_instance_multi_az/dms_instance_multi_az.metadata.json => dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.metadata.json} (100%) rename prowler/providers/aws/services/dms/{dms_instance_multi_az/dms_instance_multi_az.py => dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.py} (95%) diff --git a/prowler/providers/aws/services/dms/dms_instance_multi_az/__init__.py b/prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/__init__.py similarity index 100% rename from prowler/providers/aws/services/dms/dms_instance_multi_az/__init__.py rename to prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/__init__.py diff --git a/prowler/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az.metadata.json b/prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.metadata.json similarity index 100% rename from prowler/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az.metadata.json rename to prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.metadata.json diff --git a/prowler/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az.py b/prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.py similarity index 95% rename from prowler/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az.py rename to prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.py index 43ddf53f31..56be3cd468 100644 --- a/prowler/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az.py +++ b/prowler/providers/aws/services/dms/dms_instance_multi_az_enabled/dms_instance_multi_az_enabled.py @@ -2,7 +2,7 @@ from prowler.lib.check.models import Check, Check_Report_AWS from prowler.providers.aws.services.dms.dms_client import dms_client -class dms_instance_multi_az(Check): +class dms_instance_multi_az_enabled(Check): def execute(self): findings = [] for instance in dms_client.instances: diff --git a/prowler/providers/aws/services/dms/dms_instance_no_public_access/dms_instance_no_public_access.metadata.json b/prowler/providers/aws/services/dms/dms_instance_no_public_access/dms_instance_no_public_access.metadata.json index 8387c0c2d2..2ebbebb86f 100644 --- a/prowler/providers/aws/services/dms/dms_instance_no_public_access/dms_instance_no_public_access.metadata.json +++ b/prowler/providers/aws/services/dms/dms_instance_no_public_access/dms_instance_no_public_access.metadata.json @@ -1,6 +1,6 @@ { "Provider": "aws", - "CheckID": "dms_instance_not_public", + "CheckID": "dms_instance_no_public_access", "CheckTitle": "Ensure DMS instances are not publicly accessible.", "CheckType": [], "ServiceName": "dms", diff --git a/tests/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az_test.py b/tests/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az_test.py index d0e92a8e69..3fd5eb6022 100644 --- a/tests/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az_test.py +++ b/tests/providers/aws/services/dms/dms_instance_multi_az/dms_instance_multi_az_test.py @@ -19,11 +19,11 @@ class Test_dms_instance_multi_az: "prowler.providers.aws.services.dms.dms_service.DMS", new=dms_client, ): - from prowler.providers.aws.services.dms.dms_instance_multi_az.dms_instance_multi_az import ( - dms_instance_multi_az, + from prowler.providers.aws.services.dms.dms_instance_multi_az_enabled.dms_instance_multi_az_enabled import ( + dms_instance_multi_az_enabled, ) - check = dms_instance_multi_az() + check = dms_instance_multi_az_enabled() result = check.execute() assert len(result) == 0 @@ -47,11 +47,11 @@ class Test_dms_instance_multi_az: "prowler.providers.aws.services.dms.dms_service.DMS", new=dms_client, ): - from prowler.providers.aws.services.dms.dms_instance_multi_az.dms_instance_multi_az import ( - dms_instance_multi_az, + from prowler.providers.aws.services.dms.dms_instance_multi_az_enabled.dms_instance_multi_az_enabled import ( + dms_instance_multi_az_enabled, ) - check = dms_instance_multi_az() + check = dms_instance_multi_az_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "FAIL" @@ -83,11 +83,11 @@ class Test_dms_instance_multi_az: "prowler.providers.aws.services.dms.dms_service.DMS", new=dms_client, ): - from prowler.providers.aws.services.dms.dms_instance_multi_az.dms_instance_multi_az import ( - dms_instance_multi_az, + from prowler.providers.aws.services.dms.dms_instance_multi_az_enabled.dms_instance_multi_az_enabled import ( + dms_instance_multi_az_enabled, ) - check = dms_instance_multi_az() + check = dms_instance_multi_az_enabled() result = check.execute() assert len(result) == 1 assert result[0].status == "PASS"