From bfabc653243e1567c0c45bcd6f3ab09809516a52 Mon Sep 17 00:00:00 2001 From: HugoPBrito Date: Thu, 13 Mar 2025 20:59:54 +0100 Subject: [PATCH] refactor: rename entra_admin_mfa_enabled_for_administrative_roles --- .../__init__.py | 0 ...tive_roles_have_mfa_enabled.metadata.json} | 2 +- ..._administrative_roles_have_mfa_enabled.py} | 2 +- ...nistrative_roles_have_mfa_enabled_test.py} | 58 +++++++++---------- 4 files changed, 31 insertions(+), 31 deletions(-) rename prowler/providers/microsoft365/services/entra/{entra_admin_mfa_enabled_for_administrative_roles => entra_capolicy_administrative_roles_have_mfa_enabled}/__init__.py (100%) rename prowler/providers/microsoft365/services/entra/{entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.metadata.json => entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.metadata.json} (96%) rename prowler/providers/microsoft365/services/entra/{entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.py => entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.py} (98%) rename tests/providers/microsoft365/services/entra/{entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles_test.py => entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled_test.py} (89%) diff --git a/prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/__init__.py b/prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/__init__.py similarity index 100% rename from prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/__init__.py rename to prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/__init__.py diff --git a/prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.metadata.json b/prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.metadata.json similarity index 96% rename from prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.metadata.json rename to prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.metadata.json index 942e1a3c97..2f5f3f3ab0 100644 --- a/prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.metadata.json +++ b/prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.metadata.json @@ -1,6 +1,6 @@ { "Provider": "microsoft365", - "CheckID": "entra_admin_mfa_enabled_for_administrative_roles", + "CheckID": "entra_capolicy_administrative_roles_have_mfa_enabled", "CheckTitle": "Ensure multifactor authentication is enabled for all users in administrative roles.", "CheckType": [], "ServiceName": "entra", diff --git a/prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.py b/prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.py similarity index 98% rename from prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.py rename to prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.py index d69276f135..2d57445a26 100644 --- a/prowler/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles.py +++ b/prowler/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled.py @@ -9,7 +9,7 @@ from prowler.providers.microsoft365.services.entra.entra_service import ( ) -class entra_admin_mfa_enabled_for_administrative_roles(Check): +class entra_capolicy_administrative_roles_have_mfa_enabled(Check): """ Ensure multifactor authentication is enabled for all users in administrative roles. diff --git a/tests/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles_test.py b/tests/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled_test.py similarity index 89% rename from tests/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles_test.py rename to tests/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled_test.py index ed30be2c7a..c437099372 100644 --- a/tests/providers/microsoft365/services/entra/entra_admin_mfa_enabled_for_administrative_roles/entra_admin_mfa_enabled_for_administrative_roles_test.py +++ b/tests/providers/microsoft365/services/entra/entra_capolicy_administrative_roles_have_mfa_enabled/entra_capolicy_administrative_roles_have_mfa_enabled_test.py @@ -21,7 +21,7 @@ from tests.providers.microsoft365.microsoft365_fixtures import ( ) -class Test_entra_admin_mfa_enabled_for_administrative_roles: +class Test_entra_capolicy_administrative_roles_have_mfa_enabled: def test_no_conditional_access_policies(self): """No conditional access policies configured: expected FAIL.""" entra_client = mock.MagicMock @@ -34,17 +34,17 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = {} - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -70,12 +70,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -114,7 +114,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -144,12 +144,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -188,7 +188,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -218,12 +218,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -263,7 +263,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -298,12 +298,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -342,7 +342,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -375,12 +375,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -435,7 +435,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1 @@ -468,12 +468,12 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles.entra_client", + "prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_admin_mfa_enabled_for_administrative_roles.entra_admin_mfa_enabled_for_administrative_roles import ( - entra_admin_mfa_enabled_for_administrative_roles, + from prowler.providers.microsoft365.services.entra.entra_capolicy_administrative_roles_have_mfa_enabled.entra_capolicy_administrative_roles_have_mfa_enabled import ( + entra_capolicy_administrative_roles_have_mfa_enabled, ) entra_client.conditional_access_policies = { @@ -527,7 +527,7 @@ class Test_entra_admin_mfa_enabled_for_administrative_roles: ) } - check = entra_admin_mfa_enabled_for_administrative_roles() + check = entra_capolicy_administrative_roles_have_mfa_enabled() result = check.execute() assert len(result) == 1