From bfdff563e6fbb61992af5dd3e1f6ecfb9661a0e2 Mon Sep 17 00:00:00 2001 From: Pepe Fagoaga Date: Wed, 16 Oct 2024 13:19:10 +0200 Subject: [PATCH] chore(aws): Set scan_unused_services False by default (#5425) --- prowler/providers/aws/aws_provider.py | 5 +++-- tests/providers/aws/aws_provider_test.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/prowler/providers/aws/aws_provider.py b/prowler/providers/aws/aws_provider.py index 1a55a5d452..2843679d9a 100644 --- a/prowler/providers/aws/aws_provider.py +++ b/prowler/providers/aws/aws_provider.py @@ -84,7 +84,7 @@ class AwsProvider(Provider): profile: str = None, regions: set = set(), organizations_role_arn: str = None, - scan_unused_services: bool = None, + scan_unused_services: bool = False, resource_tags: list[str] = [], resource_arn: list[str] = [], audit_config: dict = {}, @@ -106,7 +106,7 @@ class AwsProvider(Provider): - profile: The name of the AWS CLI profile to use. - regions: A set of regions to audit. - organizations_role_arn: The ARN of the AWS Organizations IAM role to assume. - - scan_unused_services: A boolean indicating whether to scan unused services. + - scan_unused_services: A boolean indicating whether to scan unused services. False by default. - resource_tags: A list of tags to filter the resources to audit. - resource_arn: A list of ARNs of the resources to audit. - audit_config: The audit configuration. @@ -122,6 +122,7 @@ class AwsProvider(Provider): - ArgumentTypeError: If the input role session name is invalid. """ + logger.info("Initializing AWS provider ...") ######## AWS Session diff --git a/tests/providers/aws/aws_provider_test.py b/tests/providers/aws/aws_provider_test.py index 974bba9be9..0824babd93 100644 --- a/tests/providers/aws/aws_provider_test.py +++ b/tests/providers/aws/aws_provider_test.py @@ -451,7 +451,7 @@ class TestAWSProvider: aws_provider = AwsProvider(mfa=mfa) assert aws_provider.type == "aws" - assert aws_provider.scan_unused_services is None + assert aws_provider.scan_unused_services is False assert aws_provider.audit_config == {} assert ( aws_provider.session.current_session.region_name == AWS_REGION_US_EAST_1